Review main Merged

85284[BUGFIX] Keep record type value in Record object

Oli Bartsch CR +2 V +2 Easy +23 −3 updated 07/18/24, 10:48

Commit message

All fields, defined in the sub schema should
be added to the Record object, especially the
record type value.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Oli Bartsch uploaded patch set 1 07/18/24, 09:21

  2. core-ci voted on patch set 1 V +1 07/18/24, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61737

  3. Jochen Roth voted on patch set 1 CR +1 V +1 07/18/24, 09:37

  4. Oli Bartsch uploaded patch set 2 CR +1 V +1 07/18/24, 09:38

  5. Jochen Roth voted on patch set 2 CR +1 V +1 07/18/24, 09:43

  6. core-ci voted on patch set 2 V +1 07/18/24, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61738

  7. Benni Mack commented on patch set 2 CR +1 V +1 07/18/24, 10:40

    RecordFactoryTest.php:67

    you can actually just call $recordObject['type'] in the future,
  8. Oli Bartsch commented on patch set 2 CR +2 V +2 07/18/24, 10:48

    RecordFactoryTest.php:67 Reply

    Acknowledged
  9. Oli Bartsch merged patch set 3 07/18/24, 10:48