Review main Merged

85285[TASK] Extend component library examples in "Styleguide" backend module

Jasmina Ließmann CR +2 V +2 Nightmare +2830 −2207 updated 07/24/24, 14:27

Commit message

The new markup for examples, previously introduced on the Avatar
component page, has been rolled out to all example pages within the
"Styleguide" backend module. The component pages, as well as the styles
pages, are expanded to include more application examples and color
scheme examples.

In this context the CodeViewHelper has been split into three individual
ViewHelpers to make functionalities clearer.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 29

Show 9 more files

Review log 3761

Show 2236 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 07/18/24, 14:02

  2. core-ci voted on patch set 1 V -1 07/18/24, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61741

  3. Jasmina Ließmann uploaded patch set 2 V -1 07/18/24, 14:20

  4. Jasmina Ließmann uploaded patch set 3 07/18/24, 14:25

  5. Jasmina Ließmann uploaded patch set 4 07/18/24, 14:27

  6. core-ci voted on patch set 2 V -1 07/18/24, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61743

  7. core-ci voted on patch set 3 V -1 07/18/24, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61744

  8. core-ci voted on patch set 4 V -1 07/18/24, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61745

  9. Jasmina Ließmann uploaded patch set 5 V -1 07/18/24, 14:49

  10. Jasmina Ließmann uploaded patch set 6 07/18/24, 14:57

  11. core-ci voted on patch set 5 V -1 07/18/24, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61747

  12. core-ci voted on patch set 6 V -1 07/18/24, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61748

  13. Jasmina Ließmann uploaded patch set 7 V -1 07/18/24, 15:17

  14. core-ci voted on patch set 7 V -1 07/18/24, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61749

  15. core-ci voted on patch set 7 V +1 07/18/24, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61749

  16. Jasmina Ließmann uploaded patch set 8 V +1 07/23/24, 17:08

  17. core-ci voted on patch set 8 V -1 07/23/24, 17:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62031

  18. Jasmina Ließmann uploaded patch set 9 V -1 07/23/24, 18:20

  19. core-ci voted on patch set 9 V +1 07/23/24, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62037

  20. Jasmina Ließmann marked it work in progress 07/23/24, 18:36

  21. Jasmina Ließmann uploaded patch set 10 V +1 07/23/24, 20:51

  22. core-ci voted on patch set 10 V +1 07/23/24, 20:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62047

  23. Jasmina Ließmann marked it ready for review 07/23/24, 20:58

  24. Jasmina Ließmann updated the commit message in patch set 11 V +1 07/23/24, 20:59

  25. core-ci voted on patch set 11 V +1 07/23/24, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62048

  26. Jasmina Ließmann updated the commit message in patch set 12 V +1 07/24/24, 05:43

  27. core-ci voted on patch set 12 V +1 07/24/24, 05:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62069

  28. Garvin Hicking commented on patch set 12 CR +1 V +1 07/24/24, 06:58

    I love how much EXT:styleguide has evolved recently, how much better it looks and being more complete. Thank you! My code-review+1 is a bit "review-flexible", because due to file renames I just went through it superficially. The result though looks good to me, so I'm confident with my vote ;)
  29. Christian Kuhn voted on patch set 12 CR +1 V +1 07/24/24, 10:35

  30. Christian Kuhn voted on patch set 12 CR 0 V 0 07/24/24, 10:39

  31. Christian Kuhn commented on patch set 12 07/24/24, 10:40

    ComponentsController.php:367

    i'd love if we could do the template file renaming in a separate post-patch: this would help to see much better, which details in the template files were changed.
  32. Christian Kuhn uploaded patch set 13 CR +1 V +1 07/24/24, 10:49

  33. Christian Kuhn uploaded patch set 14 07/24/24, 10:50

  34. Christian Kuhn commented on patch set 14 07/24/24, 10:52

    ComponentsController.php:367 Reply

    Done
  35. Jasmina Ließmann voted on patch set 14 CR -1 07/24/24, 10:53

  36. core-ci voted on patch set 13 V +1 07/24/24, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62085

  1. Christian Kuhn commented on patch set 14 07/24/24, 10:56

    ComponentsController.php:367 Reply

    actually, we'll go back to set 22 now that includes the renaming to have a consistently named patch again.
  2. Christian Kuhn uploaded patch set 15 CR -1 07/24/24, 10:56

  3. core-ci voted on patch set 14 V +1 07/24/24, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62086

  4. Christian Kuhn commented on patch set 15 CR +1 V +1 07/24/24, 10:57

    ComponentsController.php:367 Reply

    set 12 repushed as set 15.
  5. Garvin Hicking voted on patch set 15 CR +1 V +1 07/24/24, 11:00

  6. core-ci voted on patch set 15 V +1 07/24/24, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62087

  7. Jasmina Ließmann uploaded patch set 16 CR +1 V +1 07/24/24, 12:48

  8. Jasmina Ließmann uploaded patch set 17 07/24/24, 12:49

  9. Jasmina Ließmann uploaded patch set 18 07/24/24, 12:51

  10. Jasmina Ließmann commented on patch set 18 07/24/24, 12:56

    ComponentsController.php:367 Reply

    As previously requested, the file names and actions now correspond to the current status. The renaming previously included in this patch will be done in a separate patch.
  11. core-ci voted on patch set 17 V -1 07/24/24, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62094

  12. core-ci voted on patch set 16 V -1 07/24/24, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62093

  13. Jasmina Ließmann uploaded patch set 19 07/24/24, 12:57

  14. Jasmina Ließmann uploaded patch set 20 07/24/24, 12:58

  15. Jasmina Ließmann uploaded patch set 21 07/24/24, 12:59

  16. core-ci voted on patch set 18 V -1 07/24/24, 13:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62095

  17. core-ci voted on patch set 19 V -1 07/24/24, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62098

  18. core-ci voted on patch set 20 V -1 07/24/24, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62100

  19. core-ci voted on patch set 21 V -1 07/24/24, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62101

  20. core-ci voted on patch set 20 V +1 07/24/24, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62100

  21. core-ci voted on patch set 21 V +1 07/24/24, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62101

  22. Christian Kuhn voted on patch set 21 CR +1 V +1 07/24/24, 13:59

  23. Garvin Hicking voted on patch set 21 CR +1 V +1 07/24/24, 13:59

  24. Jasmina Ließmann voted on patch set 21 CR +2 V +2 07/24/24, 14:27

  25. Jasmina Ließmann merged patch set 22 07/24/24, 14:27