85285[TASK] Extend component library examples in "Styleguide" backend module
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Garvin Hicking +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 29
- Build/Sources/Sass/module/_styleguide.scss+17 −7
- typo3/sysext/backend/Resources/Public/Css/backend.css+4 −3
- typo3/sysext/core/Tests/Acceptance/Application/Styleguide/NotificationCest.php+2 −2
- typo3/sysext/styleguide/Classes/Controller/ComponentsController.php5+60 −46
- typo3/sysext/styleguide/Classes/ViewHelpers/CodeViewHelper.php+46 −41
- typo3/sysext/styleguide/Classes/ViewHelpers/ColorSchemeViewHelper.phpnew+75 −0
- typo3/sysext/styleguide/Classes/ViewHelpers/ExampleViewHelper.phpnew+141 −0
- typo3/sysext/styleguide/Resources/Private/Language/locallang.xlf+463 −14
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Accordion.html+85 −92
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Avatar.html+20 −33
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Badges.html+46 −23
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Buttons.html+58 −62
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Cards.html+259 −578
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Checkboxes.html+264 −151
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/FlashMessages.html+25 −2
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Form.htmlrenamed+6 −8
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Infobox.html+49 −52
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Modal.html+39 −49
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Notifications.html+165 −270
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Pagination.html+238 −104
Show 9 more files
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/ProgressIndicators.html+56 −21
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Tab.html+94 −46
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Tables.html+251 −57
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Trees.html+99 −156
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Styles/ColorTokens.html+6 −6
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Styles/Icons.html+87 −198
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Styles/Shadows.html+6 −4
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Styles/Surfaces.html+10 −6
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Styles/Typography.html+159 −176
Review log 3761
Show 2236 earlier messages
-
Jasmina Ließmann uploaded patch set 1 07/18/24, 14:02
-
core-ci voted on patch set 1 V -1 07/18/24, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61741
-
Jasmina Ließmann uploaded patch set 2
V -107/18/24, 14:20 -
Jasmina Ließmann uploaded patch set 3 07/18/24, 14:25
-
Jasmina Ließmann uploaded patch set 4 07/18/24, 14:27
-
core-ci voted on patch set 2 V -1 07/18/24, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61743
-
core-ci voted on patch set 3 V -1 07/18/24, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61744
-
core-ci voted on patch set 4 V -1 07/18/24, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61745
-
Jasmina Ließmann uploaded patch set 5
V -107/18/24, 14:49 -
Jasmina Ließmann uploaded patch set 6 07/18/24, 14:57
-
core-ci voted on patch set 5 V -1 07/18/24, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61747
-
core-ci voted on patch set 6 V -1 07/18/24, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61748
-
Jasmina Ließmann uploaded patch set 7
V -107/18/24, 15:17 -
core-ci voted on patch set 7 V -1 07/18/24, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61749
-
core-ci voted on patch set 7 V +1 07/18/24, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61749
-
Jasmina Ließmann uploaded patch set 8
V +107/23/24, 17:08 -
core-ci voted on patch set 8 V -1 07/23/24, 17:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62031
-
Jasmina Ließmann uploaded patch set 9
V -107/23/24, 18:20 -
core-ci voted on patch set 9 V +1 07/23/24, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62037
-
Jasmina Ließmann marked it work in progress 07/23/24, 18:36
-
Jasmina Ließmann uploaded patch set 10
V +107/23/24, 20:51 -
core-ci voted on patch set 10 V +1 07/23/24, 20:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62047
-
Jasmina Ließmann marked it ready for review 07/23/24, 20:58
-
Jasmina Ließmann updated the commit message in patch set 11
V +107/23/24, 20:59 -
core-ci voted on patch set 11 V +1 07/23/24, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62048
-
Jasmina Ließmann updated the commit message in patch set 12
V +107/24/24, 05:43 -
core-ci voted on patch set 12 V +1 07/24/24, 05:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62069
-
Garvin Hicking commented on patch set 12 CR +1 V +1 07/24/24, 06:58
I love how much EXT:styleguide has evolved recently, how much better it looks and being more complete. Thank you! My code-review+1 is a bit "review-flexible", because due to file renames I just went through it superficially. The result though looks good to me, so I'm confident with my vote ;) -
Christian Kuhn voted on patch set 12 CR +1 V +1 07/24/24, 10:35
-
Christian Kuhn voted on patch set 12 CR 0 V 0 07/24/24, 10:39
-
Christian Kuhn commented on patch set 12 07/24/24, 10:40
ComponentsController.php:367i'd love if we could do the template file renaming in a separate post-patch: this would help to see much better, which details in the template files were changed. -
Christian Kuhn uploaded patch set 13
CR +1V +107/24/24, 10:49 -
Christian Kuhn uploaded patch set 14 07/24/24, 10:50
-
Christian Kuhn commented on patch set 14 07/24/24, 10:52
ComponentsController.php:367ReplyDone -
Jasmina Ließmann voted on patch set 14 CR -1 07/24/24, 10:53
-
core-ci voted on patch set 13 V +1 07/24/24, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62085
-
Christian Kuhn commented on patch set 14 07/24/24, 10:56
ComponentsController.php:367Replyactually, we'll go back to set 22 now that includes the renaming to have a consistently named patch again. -
Christian Kuhn uploaded patch set 15
CR -107/24/24, 10:56 -
core-ci voted on patch set 14 V +1 07/24/24, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62086
-
Christian Kuhn commented on patch set 15 CR +1 V +1 07/24/24, 10:57
ComponentsController.php:367Replyset 12 repushed as set 15. -
Garvin Hicking voted on patch set 15 CR +1 V +1 07/24/24, 11:00
-
core-ci voted on patch set 15 V +1 07/24/24, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62087
-
Jasmina Ließmann uploaded patch set 16
CR +1V +107/24/24, 12:48 -
Jasmina Ließmann uploaded patch set 17 07/24/24, 12:49
-
Jasmina Ließmann uploaded patch set 18 07/24/24, 12:51
-
Jasmina Ließmann commented on patch set 18 07/24/24, 12:56
ComponentsController.php:367ReplyAs previously requested, the file names and actions now correspond to the current status. The renaming previously included in this patch will be done in a separate patch. -
core-ci voted on patch set 17 V -1 07/24/24, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62094
-
core-ci voted on patch set 16 V -1 07/24/24, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62093
-
Jasmina Ließmann uploaded patch set 19 07/24/24, 12:57
-
Jasmina Ließmann uploaded patch set 20 07/24/24, 12:58
-
Jasmina Ließmann uploaded patch set 21 07/24/24, 12:59
-
core-ci voted on patch set 18 V -1 07/24/24, 13:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62095
-
core-ci voted on patch set 19 V -1 07/24/24, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62098
-
core-ci voted on patch set 20 V -1 07/24/24, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62100
-
core-ci voted on patch set 21 V -1 07/24/24, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62101
-
core-ci voted on patch set 20 V +1 07/24/24, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62100
-
core-ci voted on patch set 21 V +1 07/24/24, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62101
-
Christian Kuhn voted on patch set 21 CR +1 V +1 07/24/24, 13:59
-
Garvin Hicking voted on patch set 21 CR +1 V +1 07/24/24, 13:59
-
Jasmina Ließmann voted on patch set 21 CR +2 V +2 07/24/24, 14:27
-
Jasmina Ließmann merged patch set 22 07/24/24, 14:27