Review main Merged

85286[TASK] Prepare selectSingle fields to use maxitems=1

Oli Bartsch CR +2 V +2 Normal +33 −50 updated 07/20/24, 15:49

Commit message

To prevent using the renderType for checking whether
a column of SelectRelationFieldType is a single
reference, we set the maxitems option to 1. This
allows to keep existing functionality unmodified.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 24

Show 4 more files

Review log 1013

  1. Oli Bartsch uploaded patch set 1 07/18/24, 15:45

  2. core-ci voted on patch set 1 V -1 07/18/24, 15:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61750

  3. Oli Bartsch uploaded patch set 2 V -1 07/18/24, 16:05

  4. core-ci voted on patch set 2 V +1 07/18/24, 16:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61752

  5. Benni Mack voted on patch set 2 CR +1 V +1 07/18/24, 17:29

  6. Nikita Hovratov commented on patch set 2 07/19/24, 09:26

    Nice, this resolves one point in a discussion we had here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69906/8 Should we then also remove all maxitems => 1 configs within this patch, or do you want a separate patch for this?
  7. Oli Bartsch uploaded patch set 3 CR +1 V +1 07/19/24, 11:35

  8. core-ci voted on patch set 3 V +1 07/19/24, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61809

  9. Oli Bartsch commented on patch set 3 07/19/24, 11:49

    Reply

    Done
  10. Benni Mack voted on patch set 3 CR +1 V +1 07/19/24, 11:50

  11. Georg Ringer voted on patch set 3 CR +2 V +2 07/19/24, 11:51

  12. Georg Ringer merged patch set 4 07/19/24, 11:51

  13. Nikita Hovratov commented on patch set 4 07/20/24, 15:49

    Reply

    Thanks!