Review main Merged

85289[TASK] Eliminate makeInstance instantiation for stateless RecordData

Martin Adler CR +2 V +2 Easy +27 −15 updated 07/19/24, 08:23

Commit message

'RecordData' is already a stateless service and
partially injected using DI. The remaining cases
could easily be refactored to eliminate these
'makeInstance' calls.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 79

  1. Martin Adler uploaded patch set 1 07/18/24, 20:17

  2. core-ci voted on patch set 1 V -1 07/18/24, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61761

  3. Martin Adler uploaded patch set 2 V -1 07/18/24, 20:27

  4. core-ci voted on patch set 2 V +1 07/18/24, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61762

  5. Martin Adler marked it ready for review 07/18/24, 20:33

  6. Martin Adler wrote 07/18/24, 20:34

    Topic set to di
  7. Christian Kuhn voted on patch set 2 CR +1 V +1 07/19/24, 06:24

  8. Anja Leichsenring voted on patch set 2 CR +2 V +2 07/19/24, 08:23

  9. Anja Leichsenring merged patch set 3 07/19/24, 08:23