Review main Abandoned

85292[FEATURE] Add required attribute to PasswordViewHelper

Stephan Großberndt CR 0 V 0 Normal +68 −9 updated 07/19/24, 11:32

Commit message

The PasswordViewHelper is extended for a new tag
attribute "required", which can be used to
instruct the user to fill the password field.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 56

  1. Stephan Großberndt uploaded patch set 1 07/18/24, 23:11

  2. core-ci voted on patch set 1 V +1 07/18/24, 23:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61766

  3. Andreas Kienast commented on patch set 1 07/19/24, 04:28

    With the latest Fluid updates, `additionalAttributes` became obsolete in `TagBasedViewhelper` (see https://github.com/TYPO3/Fluid/pull/859). Did you check whether adding the `required` attribute works out of the box?
  4. Stephan Großberndt commented on patch set 1 07/19/24, 11:24

    Reply

    You are correct. It is not needed for v13. I was on v12.4 and pushed to main without testing. I will push the felogin improvements to another patch.
  5. Stephan Großberndt abandoned the change 07/19/24, 11:25

    Not needed for v13 due to https://github.com/TYPO3/Fluid/pull/859
  6. Stephan Großberndt commented on patch set 1 07/19/24, 11:32

    Although PHPStorm warns because of missing attributes, but this has to be solved somewhere else..