85292[FEATURE] Add required attribute to PasswordViewHelper
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-104427-RequiredAttributeForPasswordViewHelper.rstnew+34 −0
- typo3/sysext/felogin/Resources/Private/Templates/Login/Login.html+1 −1
- typo3/sysext/felogin/Resources/Private/Templates/PasswordRecovery/ShowChangePassword.html+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Form/PasswordViewHelper.php+11 −6
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/PasswordViewHelperTest.php+20 −0
Review log 56
-
Stephan Großberndt uploaded patch set 1 07/18/24, 23:11
-
core-ci voted on patch set 1 V +1 07/18/24, 23:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61766
-
Andreas Kienast commented on patch set 1 07/19/24, 04:28
With the latest Fluid updates, `additionalAttributes` became obsolete in `TagBasedViewhelper` (see https://github.com/TYPO3/Fluid/pull/859). Did you check whether adding the `required` attribute works out of the box? -
Stephan Großberndt commented on patch set 1 07/19/24, 11:24
Reply
You are correct. It is not needed for v13. I was on v12.4 and pushed to main without testing. I will push the felogin improvements to another patch. -
Stephan Großberndt abandoned the change 07/19/24, 11:25
Not needed for v13 due to https://github.com/TYPO3/Fluid/pull/859 -
Stephan Großberndt commented on patch set 1 07/19/24, 11:32
Although PHPStorm warns because of missing attributes, but this has to be solved somewhere else..