Review main Abandoned

85312[TASK] Improve ViewHelper tests for "required"

Stephan Großberndt CR 0 V 0 Normal +84 −24 updated 08/06/24, 15:04

Commit message

ViewHelpers that do not register "required" as an argument
(e.g. `PasswordViewHelper`) pass any value since
Fluid v2.12.0 (see https://github.com/TYPO3/Fluid/pull/859).

ViewHelpers that register "required" as an argument
(e.g. `TextfieldViewHelper`) interpret the specified value
as a bool and if true always render `required="required"`
and omit the attribute if false.

Review

  • Code review CR 0
  • Verified V 0

Issues 3

Files 2

Review log 58

  1. Stephan Großberndt uploaded patch set 1 07/19/24, 22:06

  2. core-ci voted on patch set 1 V -1 07/19/24, 22:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61848

  3. Stephan Großberndt uploaded patch set 2 V -1 07/19/24, 22:39

  4. core-ci voted on patch set 2 V -1 07/19/24, 22:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61850

  5. Stephan Großberndt uploaded patch set 3 V -1 07/19/24, 22:50

  6. core-ci voted on patch set 3 V +1 07/19/24, 22:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61851

  7. Christian Kuhn commented on patch set 3 08/06/24, 15:04

    hey. i hope you don't hurt me if i abandon this change: we've had https://review.typo3.org/c/Packages/TYPO3.CMS/+/85400 which also secures the 'required' argument handling, effectively testing the abstract, so this *should* be enough for now.
  8. Christian Kuhn abandoned the change 08/06/24, 15:04