Review main Merged

85317[BUGFIX] Avoid ancient injectSettings() handling

Christian Kuhn CR +2 V +2 Easy +0 −7 updated 07/21/24, 14:04

Commit message

There is some ancient when a DI method is called
'injectSettings': DI ignores this.

There is a single use for Fluid views in extbase,
which calls injectSettings if it exists manually.
However no Fluid view ever implemented this method.
It is removed.

Also, the DI magic to not call 'injectSettings'
is removed, injectSettings can now be used as
casual inject* method. This is considered a
bugfix (for main only): It is unexpected and
undocumented this handling exists.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Praetorius +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Praetorius +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Christian Kuhn uploaded patch set 1 07/21/24, 11:54

  2. core-ci voted on patch set 1 V +1 07/21/24, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61887

  3. Christian Kuhn updated the commit message in patch set 2 V +1 07/21/24, 12:26

  4. core-ci voted on patch set 2 V +1 07/21/24, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61888

  5. Simon Praetorius voted on patch set 2 CR +1 V +1 07/21/24, 12:48

  6. Benni Mack voted on patch set 2 CR +1 V +1 07/21/24, 13:21

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 07/21/24, 14:02

  8. Christian Kuhn merged patch set 3 07/21/24, 14:04