Review main Abandoned

85319[BUGFIX] Fix suggest wizard with int fields for PostgreSQL

Georg Ringer CR 0 V 0 Easy +10 −1 updated 04/09/25, 11:08

Commit message

The code needs to be adopted just as other places to make a search
within integer fields work in PostgreSQL.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1012

  1. Georg Ringer uploaded patch set 1 07/21/24, 13:44

  2. Georg Ringer commented on patch set 1 07/21/24, 13:45

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 07/21/24, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61892

  4. Stefan Bürk voted on patch set 1 CR -1 07/23/24, 11:37

  5. Stefan Bürk commented on patch set 1 07/23/24, 11:39

    This change reverts the "similar case insensitive search behaviour" for like search. Needs some adoption / other solution.
  6. Benni Mack updated the commit message in patch set 2 CR -1 V +1 10/18/24, 13:39

  7. Benni Mack rebased onto patch set 3 04/09/25, 10:19

  8. core-ci voted on patch set 3 V +1 04/09/25, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77275

  9. Christian Kuhn commented on patch set 3 04/09/25, 11:03

    when i revert the subject change and run the functional test with -d postgres, it does not fail.
  10. Christian Kuhn commented on patch set 3 04/09/25, 11:05

    Reply

    i think the issue has been fixed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/88030 with the change in ExpressionBuilder.
  11. Christian Kuhn commented on patch set 3 04/09/25, 11:08

    this issue has been fixed in our like() implementation and is covered with tests over there. we'll abandon here.
  12. Christian Kuhn abandoned the change 04/09/25, 11:08