85323[!!!][TASK] Move sitemap GET parameters into namespace
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-85323-SeoParameterNamespace.rst2new+56 −0
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/SitemapXmlCest.php+1 −1
- typo3/sysext/seo/Classes/XmlSitemap/AbstractXmlSitemapDataProvider.php+1 −1
- typo3/sysext/seo/Classes/XmlSitemap/XmlSitemapRenderer.php+1 −1
- typo3/sysext/seo/Resources/Private/Templates/XmlSitemap/Index.xml3+2 −2
- typo3/sysext/seo/Tests/Functional/XmlSitemap/AbstractXmlSitemapPagesTestCase.php+1 −1
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapIndexTest.php+1 −1
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapRecordsTest.php+3 −3
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapXslTest.php+1 −1
Review log 4358
Show 2533 earlier messages
-
Johannes Nielsen uploaded patch set 1 07/22/24, 09:28
-
Georg Ringer commented on patch set 1 CR -1 07/22/24, 09:31
please leave the previous arguments as fallback there, otherwise it would be breaking. + an important rst would be nice -
Mathias Brodala commented on patch set 1 07/22/24, 09:31
Not exactly sure if this counts as breaking change. But you should probably add an Important RST for this. Also this could be backported to v12 IMO. -
Mathias Brodala commented on patch set 1 07/22/24, 09:32
Reply
In this case the old arguments should be deprecated. -
core-ci voted on patch set 1 V -1 07/22/24, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61923
-
Georg Ringer commented on patch set 1 07/22/24, 09:39
yes because people might have added the link to some seo reporting tool + it breaks for sure routing config. so I am not sure if we should backport that at all -
Kevin Appelt commented on patch set 1 CR -1 07/22/24, 09:45
I would definitely like more feedback on whether this change should be considered breaking (I would see it as such). For example, we have URL configurations for the sitemap that no longer work with this change. -
Mathias Brodala commented on patch set 1 07/22/24, 10:04
Reply
Personally I'd be fine with not backporting. -
Johannes Nielsen commented on patch set 1 07/22/24, 10:32
Reply
I agree that in its current form this change would be breaking. I think that keeping the links using the non-namespaced parameters working would be easy – as Georg suggested, we could add a fallback. However, there are probably a gazillion other scenarios of which I am unaware that would still break. Maybe the right thing to do here would be a feature toggle? -
Johannes Nielsen uploaded patch set 2
CR -1V -107/22/24, 11:17 -
core-ci voted on patch set 2 V -1 07/22/24, 11:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61924
-
Georg Ringer voted on patch set 2 CR +1 V +1 07/22/24, 11:49
-
Markus Klein voted on patch set 2 CR +1 07/22/24, 11:58
-
Kevin Appelt commented on patch set 2 CR -1 07/22/24, 12:43
Important-85323-SeoParameterNamespace.rst:26I do not think that this is a well known feature. This should be rephrased and maybe even extended by a link like this: :ref:`Use a customized sitemap XSL file <t3coreapi:sitemap-xslFile>` And we should update the "How to setup routing for the XML sitemap" section in the docs, with a hint that the behaviour will change/changed in TYPO3 v13.3: https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Seo/XmlSitemap.html#how-to-setup-routing-for-the-xml-sitemap -
Georg Ringer commented on patch set 2 07/23/24, 07:01
IMO this is out of scope here and not needed -
Johannes Nielsen uploaded patch set 3
CR +1V +107/23/24, 08:41 -
Johannes Nielsen commented on patch set 3 07/23/24, 08:42
Important-85323-SeoParameterNamespace.rst:26ReplyI've updated the RST. You actually have to update the Index.xml, not some XSL file. I've explicitly included in the RST, what you have to do in order to have the "old" behavior. -
core-ci voted on patch set 3 V -1 07/23/24, 08:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61994
-
Johannes Nielsen rebased onto patch set 4
V -107/26/24, 06:21 -
Georg Ringer voted on patch set 4 CR +1 V +1 07/26/24, 06:21
-
core-ci voted on patch set 4 V -1 07/26/24, 06:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62247
-
Georg Ringer uploaded patch set 5
CR +1V +107/26/24, 06:38 -
core-ci voted on patch set 5 V -1 07/26/24, 06:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62249
-
Georg Ringer uploaded patch set 6
V -107/26/24, 06:50 -
core-ci voted on patch set 6 V -1 07/26/24, 06:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62252
-
Georg Ringer uploaded patch set 7
V -107/26/24, 07:03 -
core-ci voted on patch set 7 V +1 07/26/24, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62254
-
Georg Ringer voted on patch set 7 CR +1 V +1 07/26/24, 07:10
-
Stefan Bürk commented on patch set 7 CR -2 07/27/24, 01:11
temporary -2 -
Stefan Bürk voted on patch set 7 CR 0 07/27/24, 16:20
-
Benni Mack commented on patch set 7 CR -1 08/02/24, 20:14
Please at least ad a comment that we should at some point deprecate the old parameter -
Georg Ringer uploaded patch set 8
CR +1V +108/03/24, 06:33 -
core-ci voted on patch set 8 V +1 08/03/24, 06:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62785
-
Georg Ringer uploaded patch set 9
V +101/28/25, 22:55 -
Georg Ringer updated the commit message in patch set 10 01/28/25, 22:56
-
core-ci voted on patch set 9 V -1 01/28/25, 23:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73110
-
core-ci voted on patch set 10 V -1 01/28/25, 23:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73111
-
Georg Ringer uploaded patch set 11
V -101/29/25, 19:40 -
core-ci voted on patch set 11 V -1 01/29/25, 19:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73153
-
Georg Ringer uploaded patch set 12
V -101/29/25, 20:19 -
core-ci voted on patch set 12 V -1 01/29/25, 20:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73154
-
Georg Ringer uploaded patch set 13
V -101/29/25, 20:28 -
core-ci voted on patch set 13 V +1 01/29/25, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73155
-
Garvin Hicking commented on patch set 13 CR +1 V +1 01/29/25, 21:03
I'd be good with having this in as a breaking main-only change, without prior deprecation of the parameter. IMO the ReST explains what needs to be done to adapt (however, I'm never used the arguments in custom routing myself, always used the default only) -
Jörg Bösche voted on patch set 13 CR +1 02/03/25, 10:51
-
Markus Klein commented on patch set 13 02/17/25, 19:58
Maybe it should be noted that sitemaps need to be re-submitted in search engine tools too, if individual ones have been submitted in the past. -
Georg Ringer uploaded patch set 14
CR +1V +102/17/25, 20:07 -
Georg Ringer commented on patch set 14 02/17/25, 20:13
Reply
DoneReply
DoneReply
DoneImportant-85323-SeoParameterNamespace.rst:26ReplyDone -
core-ci voted on patch set 14 V +1 02/17/25, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74268
-
Garvin Hicking commented on patch set 14 CR +1 V +1 02/17/25, 21:05
Breaking-85323-SeoParameterNamespace.rst:54```suggestion In case the URL to a single sitemap has been provided to a 3rd party tool like a crawler, search engine, ... it must be added again with the new URL. ``` -
Benni Mack commented on patch set 14 02/17/25, 22:02
Index.xml:9I thought about introducing page?uid=root, so we always point to the top page, what do you think? -
Georg Ringer commented on patch set 14 02/18/25, 07:35
Index.xml:9Replynice idea but IMHO not scope of that issue I guess -
Benni Mack commented on patch set 15
CR +1V +102/18/25, 14:34Published edit on patch set 14. -
Benni Mack voted on patch set 15 CR +1 V +1 02/18/25, 14:34
-
Benni Mack commented on patch set 15 02/18/25, 14:34
Breaking-85323-SeoParameterNamespace.rst:54ReplyDoneIndex.xml:9ReplyDone -
core-ci voted on patch set 15 V +1 02/18/25, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74320
-
Georg Ringer voted on patch set 15 CR +2 V +2 02/18/25, 14:43
-
Georg Ringer merged patch set 16 02/18/25, 14:43