Review main Abandoned

85325[TASK] Update Important-102786-UpdatedDependencySymfony7.rst

TYPO3com CR 0 V 0 Easy +0 −0 updated 07/23/24, 09:25

Commit message

In the given sentence, "Dependency" is capitalized because it appears at
the beginning of a title, follows a colon, and functions as a noun.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 0

No files imported.

Review log 47

  1. TYPO3com uploaded patch set 1 07/22/24, 12:18

  2. core-ci voted on patch set 1 V +1 07/22/24, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61928

  3. Tom Müller commented on patch set 2 V +1 07/22/24, 12:25

    Published edit on patch set 1.
  4. Mathias Brodala commented on patch set 1 CR -1 07/22/24, 12:25

    Unresolved

    > In the given sentence, "Dependency" is capitalized because it appears at the beginning of a title, follows a colon, and functions as a noun. Actually no: 1. It is not at the beginning, "Important" or "Updated" are, both already capitalized 2. It does not follow a colon, but a colon follows it. 3. It is a noun but that alone does not satisfy capitalization in English. So altogether this change is not really necessary and justified.
  5. core-ci voted on patch set 2 V +1 07/22/24, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61929

  6. Andreas Kienast commented on patch set 2 CR -1 07/22/24, 13:21

    The whole PR looks invalid as the actual change has been reverted between change set 1 and 2.
  7. Georg Ringer abandoned the change 07/23/24, 09:25

    doesn'T make sense, abandoning it