85327[BUGFIX] Select pages opened via bookmark and open-docs menu in page-tree
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 13
- Build/Sources/TypeScript/backend/storage/module-state-storage.ts2+26 −13
- Build/Sources/TypeScript/backend/toolbar/shortcut-menu.ts+2 −1
- Build/Sources/TypeScript/backend/tree/page-tree-element.ts+21 −4
- Build/Sources/TypeScript/opendocs/toolbar/opendocs-menu.ts+2 −2
- typo3/sysext/backend/Classes/Domain/Model/Element/ImmediateActionElement.php+2 −2
- typo3/sysext/backend/Resources/Private/Templates/PageLayout/PageModule.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ShortcutToolbarItemDropDown.html+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/storage/module-state-storage.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/shortcut-menu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/page-tree-element.js+1 −1
- typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php+4 −1
- typo3/sysext/opendocs/Resources/Private/Templates/ToolbarItems/DropDown.html+1 −1
- typo3/sysext/opendocs/Resources/Public/JavaScript/toolbar/opendocs-menu.js+1 −1
Review log 2031
Show 36 earlier messages
-
Ayke Halder uploaded patch set 1 07/22/24, 20:22
-
core-ci voted on patch set 1 V -1 07/22/24, 20:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61936
-
Ayke Halder uploaded patch set 2
V -107/23/24, 08:08 -
core-ci voted on patch set 2 V -1 07/23/24, 08:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61993
-
Ayke Halder uploaded patch set 3
V -107/23/24, 08:47 -
core-ci voted on patch set 3 V -1 07/23/24, 08:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61995
-
Ayke Halder commented on patch set 3 07/23/24, 09:10
This change depends on https://review.typo3.org/c/Packages/TYPO3.CMS/+/85327 -
Ayke Halder commented on patch set 3 07/23/24, 09:11
Correction: depends on https://review.typo3.org/c/Packages/TYPO3.CMS/+/85288 -
Ayke Halder uploaded patch set 4
V -107/23/24, 10:35 -
core-ci voted on patch set 4 V -1 07/23/24, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62000
-
Andreas Kienast commented on patch set 4 07/23/24, 11:14
module-state-storage.ts:47In TS it's safe to check directly for undefined: `selected === undefined` -
Ayke Halder uploaded patch set 5
V -107/23/24, 12:38 -
Ayke Halder commented on patch set 5 07/23/24, 12:42
module-state-storage.ts:47ReplyGood to know! -
core-ci voted on patch set 5 V -1 07/23/24, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62008
-
Ayke Halder uploaded patch set 6
V -107/23/24, 12:51 -
core-ci voted on patch set 6 V -1 07/23/24, 12:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62009
-
Tymoteusz Motylewski commented on patch set 6 07/23/24, 13:09
Select -
Ayke Halder updated the commit message in patch set 7
V -107/23/24, 14:10 -
Ayke Halder commented on patch set 7 07/23/24, 14:11
Reply
Acknowledged -
core-ci voted on patch set 7 V -1 07/23/24, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62015
-
Ayke Halder rebased onto patch set 8
V -109/12/24, 14:08 -
Ayke Halder commented on patch set 8 09/12/24, 14:09
Reply
DoneRebased on related change. This has a proper relation chain now. -
core-ci voted on patch set 8 V -1 09/12/24, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65576
-
Ayke Halder rebased onto patch set 9
V -109/12/24, 14:30 -
core-ci voted on patch set 9 V -1 09/12/24, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65580
-
Ayke Halder rebased onto patch set 10
V -109/12/24, 15:01 -
core-ci voted on patch set 10 V +1 09/12/24, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65586
-
Ayke Halder rebased onto patch set 11
V +109/19/24, 19:40 -
core-ci voted on patch set 11 V +1 09/19/24, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66246
-
Rafael Kähm voted on patch set 11 CR +1 V +1 09/25/24, 07:43
-
Benjamin Franzke abandoned the change 02/12/25, 14:56
Thanks for picking this up. superseded by https://review.typo3.org/c/Packages/TYPO3.CMS/+/86338