Review main Abandoned

85327[BUGFIX] Select pages opened via bookmark and open-docs menu in page-tree

Ayke Halder CR 0 V 0 Normal +64 −30 updated 02/12/25, 14:56

Commit message

Pages opened via url or browser bookmark or TYPO3s shortcuts, open-docs
and recent-docs menus are marked as active/selected in the page-tree.

This refactors the structure of `CurrentState` and `StateChange` to
allow properties to be `null` (actually no change in non-strict mode).
For `CurrentState` all properties are obligatory now.

Before this change the module-state-storage could only set the
tree-node-path `selection` to the identical value as the current
record-id `identifier`. The page-tree for the module 'web' could not
work with this constraint:

* The page-id stored in `identifier` <CURRENT_ID> is used for loading
  the record-page.
* The node-path `selection` <PARENT_PARENT_ID>_<PARENT_ID>_<CURRENT_ID>
  is used to select the current tree-node.

So these can not be identical.

For translated pages this marks the `l10_parent` page as selected in
the page-tree.

Additionally this fixes some HTML attributes to correctly set the
page-id.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 13

Review log 2031

Show 36 earlier messages
  1. Ayke Halder uploaded patch set 1 07/22/24, 20:22

  2. core-ci voted on patch set 1 V -1 07/22/24, 20:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61936

  3. Ayke Halder uploaded patch set 2 V -1 07/23/24, 08:08

  4. core-ci voted on patch set 2 V -1 07/23/24, 08:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61993

  5. Ayke Halder uploaded patch set 3 V -1 07/23/24, 08:47

  6. core-ci voted on patch set 3 V -1 07/23/24, 08:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61995

  1. Ayke Halder commented on patch set 3 07/23/24, 09:10

  2. Ayke Halder commented on patch set 3 07/23/24, 09:11

  3. Ayke Halder uploaded patch set 4 V -1 07/23/24, 10:35

  4. core-ci voted on patch set 4 V -1 07/23/24, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62000

  5. Andreas Kienast commented on patch set 4 07/23/24, 11:14

    module-state-storage.ts:47

    In TS it's safe to check directly for undefined: `selected === undefined`
  6. Ayke Halder uploaded patch set 5 V -1 07/23/24, 12:38

  7. Ayke Halder commented on patch set 5 07/23/24, 12:42

    module-state-storage.ts:47 Reply

    Good to know!
  8. core-ci voted on patch set 5 V -1 07/23/24, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62008

  9. Ayke Halder uploaded patch set 6 V -1 07/23/24, 12:51

  10. core-ci voted on patch set 6 V -1 07/23/24, 12:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62009

  11. Tymoteusz Motylewski commented on patch set 6 07/23/24, 13:09

    Select
  12. Ayke Halder updated the commit message in patch set 7 V -1 07/23/24, 14:10

  13. Ayke Halder commented on patch set 7 07/23/24, 14:11

    Reply

    Acknowledged
  14. core-ci voted on patch set 7 V -1 07/23/24, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62015

  15. Ayke Halder rebased onto patch set 8 V -1 09/12/24, 14:08

  16. Ayke Halder commented on patch set 8 09/12/24, 14:09

    Reply

    Done
    Rebased on related change. This has a proper relation chain now.
  17. core-ci voted on patch set 8 V -1 09/12/24, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65576

  18. Ayke Halder rebased onto patch set 9 V -1 09/12/24, 14:30

  19. core-ci voted on patch set 9 V -1 09/12/24, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65580

  20. Ayke Halder rebased onto patch set 10 V -1 09/12/24, 15:01

  21. core-ci voted on patch set 10 V +1 09/12/24, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65586

  22. Ayke Halder rebased onto patch set 11 V +1 09/19/24, 19:40

  23. core-ci voted on patch set 11 V +1 09/19/24, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66246

  24. Rafael Kähm voted on patch set 11 CR +1 V +1 09/25/24, 07:43

  25. Benjamin Franzke abandoned the change 02/12/25, 14:56

    Thanks for picking this up. superseded by https://review.typo3.org/c/Packages/TYPO3.CMS/+/86338