Review main Merged

85328[TASK] Replace makeInstance instantiation with DI in TcaDataGenerator

Martin Adler CR +2 V +2 Hard +242 −230 updated 07/24/24, 17:46

Commit message

This patch seeks to further eliminate the usage of 'GU:makeInstance'
for stateless services in the styleguide's 'TcaDataGenerator'.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • André Buchmann +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • André Buchmann +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 2740

Show 815 earlier messages
  1. Martin Adler uploaded patch set 1 07/22/24, 21:09

  2. core-ci voted on patch set 1 V -1 07/22/24, 21:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61937

  3. Martin Adler uploaded patch set 2 07/22/24, 21:45

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  4. core-ci voted on patch set 2 V -1 07/22/24, 21:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61938

  5. Martin Adler uploaded patch set 3 V -1 07/22/24, 22:02

  6. core-ci voted on patch set 3 V +1 07/22/24, 22:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61939

  7. Martin Adler uploaded patch set 4 V +1 07/23/24, 06:39

  8. core-ci voted on patch set 4 V +1 07/23/24, 06:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61991

  9. Martin Adler uploaded patch set 5 V +1 07/23/24, 08:50

  10. core-ci voted on patch set 5 V +1 07/23/24, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61996

  11. Martin Adler uploaded patch set 6 V +1 07/23/24, 10:17

  12. core-ci voted on patch set 6 V -1 07/23/24, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61998

  13. Martin Adler uploaded patch set 7 V -1 07/23/24, 10:22

  14. Martin Adler marked it ready for review 07/23/24, 10:27

  15. core-ci voted on patch set 7 V +1 07/23/24, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61999

  1. Martin Adler marked it work in progress 07/23/24, 11:55

  2. Martin Adler uploaded patch set 8 V +1 07/23/24, 19:23

  3. core-ci voted on patch set 8 V +1 07/23/24, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62040

  4. Martin Adler uploaded patch set 9 V +1 07/23/24, 19:56

  5. Martin Adler uploaded patch set 10 07/23/24, 20:00

  6. core-ci voted on patch set 9 V -1 07/23/24, 20:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62043

  7. Martin Adler marked it ready for review 07/23/24, 20:04

  8. Martin Adler uploaded patch set 11 07/23/24, 20:06

  9. core-ci voted on patch set 10 V -1 07/23/24, 20:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62044

  10. core-ci voted on patch set 11 V +1 07/23/24, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62046

  11. Benni Mack voted on patch set 11 CR +1 V +1 07/24/24, 06:38

  12. Christian Kuhn voted on patch set 11 CR -1 07/24/24, 06:42

  13. Christian Kuhn uploaded patch set 12 CR +1 V +1 07/24/24, 09:10

  14. Christian Kuhn voted on patch set 12 CR -1 07/24/24, 09:11

  15. core-ci voted on patch set 12 V +1 07/24/24, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62079

  16. Christian Kuhn uploaded patch set 13 CR -1 V +1 07/24/24, 09:28

  17. core-ci voted on patch set 13 V +1 07/24/24, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62081

  18. Christian Kuhn commented on patch set 13 CR -1 07/24/24, 09:47

    Martin should have a second eye on this.
  19. Martin Adler commented on patch set 13 07/24/24, 12:25

    Danke fürs Anpassen sowohl in den Generatoren als auch in den `abstracts` mit inject*. Passt so!

    Generator.php:43

    💪
  20. Martin Adler commented on patch set 13 07/24/24, 12:26

    Reply

    Looks good, thank you!
  21. Martin Adler commented on patch set 13 07/24/24, 12:28

    Reply

    Darn it. German. Thanks for your changes in both `Generator` and `abstract` classes! Looks good!
  22. Christian Kuhn voted on patch set 13 CR +1 V +1 07/24/24, 12:29

  23. André Buchmann voted on patch set 13 CR +1 V +1 07/24/24, 14:35

  24. Georg Ringer voted on patch set 13 CR +2 V +2 07/24/24, 17:46

  25. Georg Ringer merged patch set 14 07/24/24, 17:46