85328[TASK] Replace makeInstance instantiation with DI in TcaDataGenerator
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Christian Kuhn +1
- André Buchmann +1
-
Verified V +2 Done
- Georg Ringer +2
- Christian Kuhn +1
- André Buchmann +1
- core-ci +1 CI
Issues 1
Files 14
- typo3/sysext/core/Tests/Acceptance/Support/Extension/ApplicationEnvironment.php+3 −3
- typo3/sysext/styleguide/Classes/Command/GeneratorCommand.php+14 −18
- typo3/sysext/styleguide/Classes/Controller/PageTreesController.php+13 −20
- typo3/sysext/styleguide/Classes/TcaDataGenerator/TableHandler/AbstractTableHandler.php+8 −4
- typo3/sysext/styleguide/Classes/TcaDataGenerator/TableHandler/General.php+10 −9
- typo3/sysext/styleguide/Classes/TcaDataGenerator/TableHandler/InlineMn.php+22 −17
- typo3/sysext/styleguide/Classes/TcaDataGenerator/TableHandler/InlineMnGroup.php+20 −17
- typo3/sysext/styleguide/Classes/TcaDataGenerator/TableHandler/InlineMnSymmetric.php+18 −17
- typo3/sysext/styleguide/Classes/TcaDataGenerator/TableHandler/InlineMnSymmetricGroup.php+16 −17
- typo3/sysext/styleguide/Classes/TcaDataGenerator/TableHandler/StaticData.php+20 −15
- typo3/sysext/styleguide/Classes/TcaDataGenerator/AbstractGenerator.php+15 −3
- typo3/sysext/styleguide/Classes/TcaDataGenerator/Generator.php1+19 −19
- typo3/sysext/styleguide/Classes/TcaDataGenerator/GeneratorFrontend.php+51 −60
- typo3/sysext/styleguide/Classes/TcaDataGenerator/RecordFinder.php+13 −11
Review log 2740
Show 815 earlier messages
-
Martin Adler uploaded patch set 1 07/22/24, 21:09
-
core-ci voted on patch set 1 V -1 07/22/24, 21:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61937
-
Martin Adler uploaded patch set 2 07/22/24, 21:45
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 2 V -1 07/22/24, 21:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61938
-
Martin Adler uploaded patch set 3
V -107/22/24, 22:02 -
core-ci voted on patch set 3 V +1 07/22/24, 22:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61939
-
Martin Adler uploaded patch set 4
V +107/23/24, 06:39 -
core-ci voted on patch set 4 V +1 07/23/24, 06:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61991
-
Martin Adler uploaded patch set 5
V +107/23/24, 08:50 -
core-ci voted on patch set 5 V +1 07/23/24, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61996
-
Martin Adler uploaded patch set 6
V +107/23/24, 10:17 -
core-ci voted on patch set 6 V -1 07/23/24, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61998
-
Martin Adler uploaded patch set 7
V -107/23/24, 10:22 -
Martin Adler marked it ready for review 07/23/24, 10:27
-
core-ci voted on patch set 7 V +1 07/23/24, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61999
-
Martin Adler marked it work in progress 07/23/24, 11:55
-
Martin Adler uploaded patch set 8
V +107/23/24, 19:23 -
core-ci voted on patch set 8 V +1 07/23/24, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62040
-
Martin Adler uploaded patch set 9
V +107/23/24, 19:56 -
Martin Adler uploaded patch set 10 07/23/24, 20:00
-
core-ci voted on patch set 9 V -1 07/23/24, 20:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62043
-
Martin Adler marked it ready for review 07/23/24, 20:04
-
Martin Adler uploaded patch set 11 07/23/24, 20:06
-
core-ci voted on patch set 10 V -1 07/23/24, 20:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62044
-
core-ci voted on patch set 11 V +1 07/23/24, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62046
-
Benni Mack voted on patch set 11 CR +1 V +1 07/24/24, 06:38
-
Christian Kuhn voted on patch set 11 CR -1 07/24/24, 06:42
-
Christian Kuhn uploaded patch set 12
CR +1V +107/24/24, 09:10 -
Christian Kuhn voted on patch set 12 CR -1 07/24/24, 09:11
-
core-ci voted on patch set 12 V +1 07/24/24, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62079
-
Christian Kuhn uploaded patch set 13
CR -1V +107/24/24, 09:28 -
core-ci voted on patch set 13 V +1 07/24/24, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62081
-
Christian Kuhn commented on patch set 13 CR -1 07/24/24, 09:47
Martin should have a second eye on this. -
Martin Adler commented on patch set 13 07/24/24, 12:25
Danke fürs Anpassen sowohl in den Generatoren als auch in den `abstracts` mit inject*. Passt so!Generator.php:43💪 -
Martin Adler commented on patch set 13 07/24/24, 12:26
Reply
Looks good, thank you! -
Martin Adler commented on patch set 13 07/24/24, 12:28
Reply
Darn it. German. Thanks for your changes in both `Generator` and `abstract` classes! Looks good! -
Christian Kuhn voted on patch set 13 CR +1 V +1 07/24/24, 12:29
-
André Buchmann voted on patch set 13 CR +1 V +1 07/24/24, 14:35
-
Georg Ringer voted on patch set 13 CR +2 V +2 07/24/24, 17:46
-
Georg Ringer merged patch set 14 07/24/24, 17:46