85336[BUGFIX] Free ext:form ConfirmationFinisher COR calls from extbase
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Markus Klein +1
- Simon Praetorius +1
-
Verified V +2 Done
- Christian Kuhn +2
- Markus Klein +1
- Simon Praetorius +1
- core-ci +1 CI
Issues 5
- Bug #104462ConfirmationFinisher with content element uid causes error in frontend
- Task #100623Provide current content object as request attribute
- Task #104472Avoid action magic in getControllerActionName()
- Task #104471Avoid munging Request in Fluid RenderingContext
- Task #104473Reduce extbase magic in FluidTemplateContentObject
Files 1
Review log 1822
-
Markus Klein uploaded patch set 1 07/23/24, 13:59
-
core-ci voted on patch set 1 V +1 07/23/24, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62013
-
Georg Ringer commented on patch set 1 07/23/24, 14:23
question is why you are affected but nobody else? pretty sure people are using this finisher quite a lot -
Markus Klein commented on patch set 1 07/23/24, 23:43
Reply
My only guess: Most people are using only the message option and not the contentElementUid option. -
Christian Kuhn commented on patch set 1 CR -1 07/24/24, 10:16
ConfirmationFinisher.php:103COR pulls request from globals if not given (but needed), and this should be avoided. i think we should understand *why* this fixes the issue, to see if this is actually a good solution. i'll -1 for now. -
Christian Kuhn commented on patch set 1 07/24/24, 21:23
ConfirmationFinisher.php:103Reply$this->contentObjectRenderer->setRequest($this->finisherContext->getRequest()->withoutAttribute('extbase')); Cloud you please test this? I'm quite confident this will solve the issue and is the better solution. I can explain details if you give it a go. Related (but v13 only): https://review.typo3.org/c/Packages/TYPO3.CMS/+/85346 - plus a couple of further patches we started to prepare to reduce the mess in this area ... -
Markus Klein commented on patch set 1 07/25/24, 07:06
We found out that the CE needs to reside on a sysfolder in order to trigger this issue. (We did look into it, why this matters, yet)ConfirmationFinisher.php:103ReplyConfirmed, this solves the issue too. -
Christian Kuhn uploaded patch set 2
CR -1V +107/25/24, 10:23 -
Christian Kuhn commented on patch set 2 CR +1 V +1 07/25/24, 10:26
ConfirmationFinisher.php:103ReplyDone -
Christian Kuhn commented on patch set 2 07/25/24, 10:30
Reply
it needs some further setup details to actually trigger a problem, probably involving calls to ConfigurationManager within the COR sub request. -
core-ci voted on patch set 2 V +1 07/25/24, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62167
-
Simon Praetorius voted on patch set 2 CR +1 V +1 07/25/24, 10:38
-
Christian Kuhn uploaded patch set 3
CR +1V +107/25/24, 10:47 -
Christian Kuhn voted on patch set 3 CR +1 V +1 07/25/24, 10:48
-
Markus Klein updated the commit message in patch set 4
CR +1V +107/25/24, 10:48 -
Markus Klein voted on patch set 4 CR +1 V +1 07/25/24, 10:49
-
Simon Praetorius voted on patch set 4 CR +1 V +1 07/25/24, 10:49
-
Christian Kuhn voted on patch set 4 CR +1 V +1 07/25/24, 10:49
-
core-ci voted on patch set 4 V +1 07/25/24, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62176
-
core-ci voted on patch set 3 V -1 07/25/24, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62175
-
Christian Kuhn voted on patch set 4 CR +2 V +2 07/25/24, 11:10
-
Christian Kuhn merged patch set 5 07/25/24, 11:10