Review main Merged

85340[TASK] Update card layout in "Reports overview" view of EXT:report

Jasmina Ließmann CR +2 V +2 Normal +44 −43 updated 07/24/24, 17:45

Commit message

This patch standardizes the appearance of the cards in the "Reports
overview" view with those from the "About" module and the "Admin
Tools" area.

Since this was the last occurrence where a card was used directly as
a link, the corresponding CSS settings are also removed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1317

  1. Jasmina Ließmann uploaded patch set 1 07/24/24, 06:33

  2. core-ci voted on patch set 1 V +1 07/24/24, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62070

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 07/24/24, 07:08

  4. Ayke Halder commented on patch set 1 07/24/24, 07:11

    Please also remove the `a.card` styles from `Build/Sources/Sass/component/_card.scss`.
  5. Jasmina Ließmann uploaded patch set 2 CR +1 V +1 07/24/24, 07:35

  6. Jasmina Ließmann commented on patch set 2 07/24/24, 07:37

    Reply

    Done
  7. core-ci voted on patch set 2 V +1 07/24/24, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62073

  8. Garvin Hicking voted on patch set 2 CR +1 V +1 07/24/24, 08:09

  9. Ayke Halder commented on patch set 2 07/24/24, 09:47

    Improve a11y for link with button style.

    Index.html:44

    This behaves like a button: we might add `role="button"` for accessibility.
  10. Christian Kuhn voted on patch set 2 CR +1 V +1 07/24/24, 09:51

  11. Jasmina Ließmann uploaded patch set 3 CR +1 V +1 07/24/24, 13:08

  12. Jasmina Ließmann commented on patch set 2 07/24/24, 13:08

    Index.html:44 Reply

    Done
  13. Garvin Hicking voted on patch set 3 CR +1 V +1 07/24/24, 13:18

  14. core-ci voted on patch set 3 V -1 07/24/24, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62102

  15. core-ci voted on patch set 3 V +1 07/24/24, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62102

  16. Georg Ringer voted on patch set 3 CR +2 V +2 07/24/24, 17:45

  17. Georg Ringer merged patch set 4 07/24/24, 17:45