Review main Merged

85342[TASK] Avoid $this->request in LinkValidatorController

Christian Kuhn CR +2 V +2 Easy +11 −14 updated 07/24/24, 10:41

Commit message

$request is hand around already. There is no
reason to assign it to $this.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 07/24/24, 10:01

  2. core-ci voted on patch set 1 V +1 07/24/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62082

  3. Christian Kuhn rebased onto patch set 2 V +1 07/24/24, 10:18

  4. Garvin Hicking voted on patch set 2 CR +1 V +1 07/24/24, 10:20

  5. core-ci voted on patch set 2 V +1 07/24/24, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62083

  6. Andreas Nedbal voted on patch set 2 CR +1 V +1 07/24/24, 10:40

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 07/24/24, 10:41

  8. Christian Kuhn merged patch set 3 07/24/24, 10:41