Review main Merged

85347[TASK] Avoid action magic in getControllerActionName()

Christian Kuhn CR +2 V +2 Easy +0 −24 updated 07/25/24, 11:12

Commit message

Extbase has some code within ExtbaseRequestParameters
->getControllerActionName() that fetches all methods
from the given controller class to see if the
previously set action name is in there. The comparison
includes some case insensitivity magic and in the
end tries to return an action name which is cased
exactly as the method within the controller.

This code has been added to flow3 back in 2010 and
was back ported to extbase around that time. It was
however never relevant in extbase: The extbase
RequestBuilder has an earlier step where it
compares the requested action with the list of
allowed registered actions (via ConfigurationManager)
and throws an exception if there is no
(case sensitive!) match.

The simplifies getControllerActionName() by
removing this obsolete code.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Praetorius +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Praetorius +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Christian Kuhn uploaded patch set 1 07/24/24, 23:20

  2. core-ci voted on patch set 1 V +1 07/24/24, 23:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62122

  3. Christian Kuhn updated the commit message in patch set 2 V +1 07/24/24, 23:49

  4. core-ci voted on patch set 2 V +1 07/24/24, 23:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62123

  5. Benni Mack voted on patch set 2 CR +1 V +1 07/25/24, 09:12

  6. Simon Praetorius voted on patch set 2 CR +1 V +1 07/25/24, 09:29

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 07/25/24, 11:12

  8. Christian Kuhn merged patch set 3 07/25/24, 11:12