Review main Merged

85348[TASK] Reduce extbase magic in FluidTemplateContentObject

Christian Kuhn CR +2 V +2 Easy +0 −25 updated 07/25/24, 11:11

Commit message

FluidTemplateContentObject has some magic to adapt
the given request *if* the request is an extbase
request already.

This code is relatively obviously obsolete: Only
extbase bootstrap creates extbase requests (and
actually, the code *below* the lines changed by
this patch in FluidTemplateContentObject, those
will see a separate deprecation or removal patch,
soon).

So, when FluidTemplateContentObject is called
for whatever reason with an extbase request, it
has been created by a proper extbase bootstrap
call, wich created a "correct" extbase request
already. There is no need to tamper with this
in FluidTemplateContentObject again. Note this
wasn't the case with earlier TYPO3 versions where
extbase requests were created within StandaloneView,
a misuse we got rid off in v12.

The patch removes these extbase request
manipulations from FluidTemplateContentObject.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Praetorius +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Praetorius +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 4

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 07/24/24, 23:58

  2. core-ci voted on patch set 1 V +1 07/25/24, 00:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62124

  3. Christian Kuhn updated the commit message in patch set 2 V +1 07/25/24, 00:34

  4. core-ci voted on patch set 2 V +1 07/25/24, 00:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62125

  5. Benni Mack voted on patch set 2 CR +1 V +1 07/25/24, 09:12

  6. Simon Praetorius voted on patch set 2 CR +1 V +1 07/25/24, 09:32

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 07/25/24, 11:11

  8. Christian Kuhn merged patch set 3 07/25/24, 11:11