Review main Merged

85350[BUGFIX] Fix PhpIntegrityCheck result if one check catches issues

Anja Leichsenring CR +2 V +2 Easy +7 −2 updated 07/25/24, 10:45

Commit message

The was a wrong accumulation in place that made the checker report
success while the output clearly stated exceptionCodeChecker found
issues.
Accumulation and final status report were fixed to properly report
the checker failing in this case.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Anja Leichsenring uploaded patch set 1 07/25/24, 06:37

  2. core-ci voted on patch set 1 V +1 07/25/24, 06:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62155

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 07/25/24, 09:19

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 07/25/24, 10:40

  5. Anja Leichsenring voted on patch set 1 CR +2 V +2 07/25/24, 10:45

  6. Anja Leichsenring merged patch set 2 07/25/24, 10:45