85351[TASK] runTests.sh: Show phpstan memory consumption
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Mathias Brodala +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1015
-
Christian Kuhn uploaded patch set 1 07/25/24, 08:53
-
core-ci voted on patch set 1 V +1 07/25/24, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62157
-
Mathias Brodala commented on patch set 1 07/25/24, 09:00
IMO --verbose should be used instead for better visibility and readability. Generally short options should be preserved for humans to type. Scripts and documentation should always use long options for clarity. -
Christian Kuhn uploaded patch set 2
V +107/25/24, 09:07 -
Christian Kuhn commented on patch set 2 07/25/24, 09:08
Reply
but i am human when i typed this into the script ;) -
Mathias Brodala updated the commit message in patch set 3 07/25/24, 09:09
-
Mathias Brodala voted on patch set 3 CR +1 07/25/24, 09:09
-
Benni Mack voted on patch set 3 CR +1 V +1 07/25/24, 09:10
-
core-ci voted on patch set 2 V -1 07/25/24, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62160
-
core-ci voted on patch set 3 V -1 07/25/24, 09:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62163
-
core-ci voted on patch set 3 V +1 07/25/24, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62163
-
core-ci voted on patch set 2 V +1 07/25/24, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62160
-
Oli Bartsch voted on patch set 3 CR +1 V +1 07/25/24, 09:53
-
Christian Kuhn voted on patch set 3 CR +2 V +2 07/25/24, 09:57
-
Christian Kuhn merged patch set 4 07/25/24, 09:58