Review main Merged

85351[TASK] runTests.sh: Show phpstan memory consumption

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 07/25/24, 09:58

Commit message

phpstan can be very memory hungry. Option --verbose
adds a line about 'peak memory' usage to the output.
Add this to get a better feeling of the memory usage.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Mathias Brodala +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1015

  1. Christian Kuhn uploaded patch set 1 07/25/24, 08:53

  2. core-ci voted on patch set 1 V +1 07/25/24, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62157

  3. Mathias Brodala commented on patch set 1 07/25/24, 09:00

    IMO --verbose should be used instead for better visibility and readability. Generally short options should be preserved for humans to type. Scripts and documentation should always use long options for clarity.
  4. Christian Kuhn uploaded patch set 2 V +1 07/25/24, 09:07

  5. Christian Kuhn commented on patch set 2 07/25/24, 09:08

    Reply

    but i am human when i typed this into the script ;)
  6. Mathias Brodala updated the commit message in patch set 3 07/25/24, 09:09

  7. Mathias Brodala voted on patch set 3 CR +1 07/25/24, 09:09

  8. Benni Mack voted on patch set 3 CR +1 V +1 07/25/24, 09:10

  9. core-ci voted on patch set 2 V -1 07/25/24, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62160

  10. core-ci voted on patch set 3 V -1 07/25/24, 09:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62163

  11. core-ci voted on patch set 3 V +1 07/25/24, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62163

  12. core-ci voted on patch set 2 V +1 07/25/24, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62160

  13. Oli Bartsch voted on patch set 3 CR +1 V +1 07/25/24, 09:53

  14. Christian Kuhn voted on patch set 3 CR +2 V +2 07/25/24, 09:57

  15. Christian Kuhn merged patch set 4 07/25/24, 09:58