85372[FEATURE] Add `if()` expression support to `ExpressionBuilder`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Anja Leichsenring +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/core/Classes/Database/Query/Expression/ExpressionBuilder.php4+47 −0
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-104482-IfSupportInExpressionBuilder.rst2new+87 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/DataSet/TestExpressionBuilderIf.csvnew+4 −0
- typo3/sysext/core/Tests/Functional/Database/Query/Expression/ExpressionBuilderTest.php+38 −0
Review log 1925
-
Stefan Bürk uploaded patch set 1 07/25/24, 10:27
-
core-ci voted on patch set 1 V +1 07/25/24, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62169
-
Stefan Bürk rebased onto patch set 2
V +107/25/24, 17:43 -
core-ci voted on patch set 2 V +1 07/25/24, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62206
-
Stefan Bürk uploaded patch set 3
V +107/25/24, 18:59 -
core-ci voted on patch set 3 V +1 07/25/24, 19:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62220
-
Stefan Bürk wrote 07/25/24, 19:16
Topic set to doctrine/dbal -
Stefan Bürk wrote 07/25/24, 19:16
Topic doctrine/dbal removed -
Stefan Bürk wrote 07/25/24, 19:16
Topic set to doctrine-dbal -
Christian Kuhn voted on patch set 3 CR -1 07/25/24, 20:19
-
Christian Kuhn uploaded patch set 4
CR -1V +107/25/24, 20:32 -
core-ci voted on patch set 4 V +1 07/25/24, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62226
-
Christian Kuhn uploaded patch set 5
V +107/25/24, 20:37 -
Christian Kuhn voted on patch set 5 CR +1 V +1 07/25/24, 20:40
-
core-ci voted on patch set 5 V +1 07/25/24, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62227
-
Anja Leichsenring voted on patch set 5 CR +1 V +1 07/26/24, 04:42
-
Garvin Hicking commented on patch set 5 07/26/24, 05:27
ExpressionBuilder.php:1004Is "literal" instead of "quote" here (and in the docs) a better way to keep it consistent?ExpressionBuilder.php:1013missing ' after page-is-not-visibleFeature-104482-IfSupportInExpressionBuilder.rst:78Add a note here indicating that escaping on all parts of the condition and the then/else parts is required? -
Stefan Bürk uploaded patch set 6
CR +1V +107/26/24, 07:30 -
Stefan Bürk commented on patch set 6 07/26/24, 07:30
ExpressionBuilder.php:1004ReplyExpressionBuilder->literal() is just calling QueryBuilder->quote() anyway. Both legit. Personally I never use ExpressionBuilder->literal().ExpressionBuilder.php:1013ReplyDoneFeature-104482-IfSupportInExpressionBuilder.rst:78ReplyDone -
core-ci voted on patch set 6 V +1 07/26/24, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62256
-
Anja Leichsenring voted on patch set 6 CR +1 V +1 07/26/24, 07:40
-
Georg Ringer voted on patch set 6 CR +1 V +1 07/26/24, 07:46
-
Stefan Bürk voted on patch set 6 CR +2 V +2 07/26/24, 07:46
-
Stefan Bürk merged patch set 7 07/26/24, 07:47
-
Georg Ringer voted on patch set 6 CR +2 V +2 07/26/24, 07:49