Review main Merged

85373[TASK] Add `page` workspace overlay resolving in RootlineUtility

Stefan Bürk CR +2 V +2 Normal +183 −16 updated 07/30/24, 13:31

Commit message

The change switches the current page record workspace
overlay handling in RootlineUtility from a series of
three simple queries to a nifty single query. The
complexity of that single query is worth it, since
this code part is called often in FE.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1629

Show 24 earlier messages
  1. Stefan Bürk uploaded patch set 1 07/25/24, 10:27

  2. core-ci voted on patch set 1 V -1 07/25/24, 10:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62170

  3. Stefan Bürk uploaded patch set 2 V -1 07/25/24, 10:44

  4. core-ci voted on patch set 2 V +1 07/25/24, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62172

  1. Stefan Bürk rebased onto patch set 3 V +1 07/25/24, 17:43

  2. core-ci voted on patch set 3 V +1 07/25/24, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62207

  3. Stefan Bürk uploaded patch set 4 V +1 07/25/24, 18:59

  4. core-ci voted on patch set 4 V +1 07/25/24, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62221

  5. Stefan Bürk rebased onto patch set 5 V +1 07/26/24, 08:08

  6. core-ci voted on patch set 5 V +1 07/26/24, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62259

  7. Stefan Bürk uploaded patch set 6 V +1 07/27/24, 16:45

  8. core-ci voted on patch set 6 V -1 07/27/24, 16:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62309

  9. core-ci voted on patch set 6 V +1 07/27/24, 17:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62309

  10. Stefan Bürk rebased onto patch set 7 V +1 07/27/24, 23:53

  11. core-ci voted on patch set 7 V -1 07/28/24, 00:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62322

  12. Stefan Bürk rebased onto patch set 8 V -1 07/28/24, 01:40

  13. core-ci voted on patch set 8 V +1 07/28/24, 01:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62328

  14. Stefan Bürk rebased onto patch set 9 V +1 07/29/24, 21:48

  15. core-ci voted on patch set 9 V +1 07/29/24, 21:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62399

  16. Georg Ringer commented on patch set 9 07/30/24, 06:12

    I am not sure if we should use the word "simplify"? this change is not making something more simple, it adds complexity which will be fore sure well tested and coded but simple is not the word we should use. performance comes with guilt ^^
  17. Stefan Bürk updated the commit message in patch set 10 V +1 07/30/24, 06:16

  18. core-ci voted on patch set 10 V +1 07/30/24, 06:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62415

  19. Christian Kuhn uploaded patch set 11 V +1 07/30/24, 12:15

  20. core-ci voted on patch set 11 V -1 07/30/24, 12:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62438

  21. core-ci voted on patch set 11 V +1 07/30/24, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62438

  22. Christian Kuhn voted on patch set 11 CR +1 V +1 07/30/24, 12:28

  23. Anja Leichsenring voted on patch set 11 CR +1 V +1 07/30/24, 13:09

  24. Stefan Bürk voted on patch set 11 CR +2 V +2 07/30/24, 13:31

  25. Stefan Bürk merged patch set 12 07/30/24, 13:31