Review main Merged

85375[TASK] Reduce phpstan memory usage

Christian Kuhn CR +2 V +2 Easy +3 −0 updated 07/25/24, 12:28

Commit message

phpstan "bleeding edge config" enables a feature that
reduces memory usage significantly. We don't switch
to "bleeding edge" per se, but enable that single
toggle for now. phpstan does not do this by default
since it may be breaking for existing rules, which is
not a problem in our case.

> rm -rf .cache/phpstan/; Build/Scripts/runTests.sh -s phpstan

Before locally: 10.99 GB
After locally: 5.82 GB
Before CI: 15.15 GB
After CI: 9.49 GB

Numbers vary depending mainly on available number of CPUs:
My local machine has less CPUs than CI - we *may* tune
phpstan a bit further in this area, later.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 69

  1. Christian Kuhn uploaded patch set 1 07/25/24, 10:45

  2. Christian Kuhn uploaded patch set 2 07/25/24, 10:57

  3. core-ci voted on patch set 1 V -1 07/25/24, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62174

  4. core-ci voted on patch set 2 V -1 07/25/24, 11:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62178

  5. core-ci voted on patch set 2 V +1 07/25/24, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62178

  6. Garvin Hicking commented on patch set 2 CR +1 V +1 07/25/24, 12:17

    Let's try it, what could possibl
  7. Stefan Bürk voted on patch set 2 CR +1 V +1 07/25/24, 12:25

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 07/25/24, 12:28

  9. Christian Kuhn merged patch set 3 07/25/24, 12:28