Review 12.4 Merged

85376[BUGFIX] Free ext:form ConfirmationFinisher COR calls from extbase

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 07/25/24, 11:10

Commit message

* ext:form is FE an extbase plugin and operates with an
  extbase request created by extbase bootstrap (or by
  FluidTemplateContentObject, but that's a different story).
* ConfirmationFinisher has option 'contentElementUid', which
  - when set - creates a ContentObjectRenderer to render
  specific content elements.
* ContentObjectRenderer then often renders this content
  element using FluidTemplateContentObject. Various code
  within Fluid rendering then applies magic to create new
  requests, *if* an extbase request is given. This can lead
  to broken template resolving when rendering in
  FluidTemplateContentObject.

This entire thing is quite messy. We're taking measures to
resolve the underlying flaws in v13. To fix the situation
in v12, the idea is like that: When ConfirmationFinisher
calls ContentObjectRenderer and hands over its request, it
should "free" that request from its own extbase context
to not trigger pollution by code that does things if an
extbase request is given.

Note this was not an issue in v11 since only v12 started
handing over the extbase request to ContentObjectRenderer,
in v11 it was indirectly pulled from $GLOBALS['TYPO3_REQUEST']
within ContentObjectRenderer, which is the "original" request
before it is turned into an extbase request by extbase
plugin bootstrap.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 5

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 07/25/24, 10:50

  2. core-ci voted on patch set 1 V +1 07/25/24, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62177

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 07/25/24, 11:10

  4. Christian Kuhn merged patch set 2 07/25/24, 11:10