Review 12.4 Merged

85379[BUGFIX] Fix variable key loop to avoid DB compare issues

Stefan Bürk CR +2 V +2 Easy +2 −2 updated 07/25/24, 19:03

Commit message

With #93223 minor index handling within the Database
Analyzer Stack was fixed.

Via DBAL 4 changes in "main" (and not 12.4),
some variable names in loops were changed. When
backporting #93223 to 12.4, these changes were
not carried over, which led to an inner loop
re-using a variable name from the outer loop.

Due to this, the index name generation could not
properly recognize all renamed keys, and only
the last renamed key was recognized in the
Database Analyzer.

This patch adjusts the inner and outer loop
variable names to be unique and in line with
what is in place in "main".

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Sergio Catalá +1
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Sergio Catalá +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 911

  1. Stefan Bürk uploaded patch set 1 07/25/24, 11:13

  2. core-ci voted on patch set 1 V +1 07/25/24, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62183

  3. Garvin Hicking voted on patch set 1 CR +1 07/25/24, 16:15

  4. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 07/25/24, 16:24

  5. Garvin Hicking voted on patch set 2 CR +1 07/25/24, 16:24

  6. core-ci voted on patch set 2 V +1 07/25/24, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62200

  7. Sergio Catalá voted on patch set 2 V +1 07/25/24, 17:27

  8. Sergio Catalá voted on patch set 2 CR +1 07/25/24, 17:27

  9. Christian Kuhn voted on patch set 2 CR +1 V +1 07/25/24, 19:03

  10. Stefan Bürk voted on patch set 2 CR +2 V +2 07/25/24, 19:03

  11. Stefan Bürk merged patch set 3 07/25/24, 19:03