Review main Merged

85384[TASK] Tame extbase ConfigurationManager

Christian Kuhn CR +2 V +2 Expert +515 −1433 updated 08/08/24, 17:20

Commit message

The extbase ConfigurationManager is - even after various
refactoring loops - still an anti pattern: This is a
stateful singleton initialized by extbase bootstrap with
state, and it can be injected into arbitrary classes.

This patch still does not solve the root of this issue:
It is still unclear on how to solve it.

The patch however now makes the two "worker" classes
stateless: Both the "concrete" implementation classes
FrontendConfigurationManager and BackendConfigurationManager.
This strategy bundles the ConfigurationManager flaws into
one class now. The patch also moves an access to
$GLOBALS['TYPO3_REQUEST'] out of __construct(), which
allows us to deprecate this call with an upcoming patch.

Note there is also TYPO3\CMS\Extbase\Service\ExtensionService,
which is *another* stateful injectable singleton, that works
on ConfigurationManager - #messDoesNotEndHere

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 19