Review main Merged

85387[TASK] Remove hyphen prefix from sys_log's data field entry

Georg Ringer CR +2 V +2 Easy +25 −1 updated 03/26/25, 13:18

Commit message

Prefixing the logged context info in sys_log's field data with a `-`
doesn't make any sense. Additionally it is harder to extract the data by
3rd party tools.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2429

Show 34 earlier messages
  1. Georg Ringer uploaded patch set 1 07/26/24, 07:18

  2. Georg Ringer commented on patch set 1 07/26/24, 07:18

    This change is ready for review.
  3. Mathias Brodala voted on patch set 1 CR +1 07/26/24, 07:21

  4. core-ci voted on patch set 1 V +1 07/26/24, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62255

  1. Garvin Hicking commented on patch set 1 07/26/24, 08:14

    Hm, this will lead to two formats in "legacy" log tables. We should at least add an important.rst file to mention this, and that custom extraction of the field may need adaptation. There's no TYPO3 internal extraction/reading of this column, right?
  2. Andy Abderhalden voted on patch set 1 V +1 07/26/24, 09:10

  3. Markus Klein commented on patch set 1 07/26/24, 10:23

    Reply

    Definitely needs an Important rst and maybe a dedicated info in the release notes. This will - most likely - break any custom monitoring system.
  4. Georg Ringer uploaded patch set 2 CR +1 V +1 07/27/24, 08:42

  5. core-ci voted on patch set 2 V +1 07/27/24, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62297

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 07/27/24, 09:14

  7. Garvin Hicking commented on patch set 2 07/27/24, 09:15

    Reply

    Done
  8. Markus Klein commented on patch set 3 CR +1 V +1 07/28/24, 21:27

    Published edit on patch set 2.
  9. Markus Klein voted on patch set 3 CR +1 V +1 07/28/24, 21:27

  10. Garvin Hicking voted on patch set 3 CR +1 V +1 07/28/24, 21:30

  11. core-ci voted on patch set 3 V +1 07/28/24, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62348

  12. Andreas Kienast commented on patch set 3 07/29/24, 06:29

    Important-104477-RemoveHyphenPrefixFromSys_logsDataFieldEntry.rst:20

    Wouldn't it make sense to offer an upgrade wizard?
  13. Mathias Brodala commented on patch set 3 07/29/24, 07:08

    Important-104477-RemoveHyphenPrefixFromSys_logsDataFieldEntry.rst:20 Reply

    Acknowledged
  14. Benni Mack updated the commit message in patch set 4 CR +1 V +1 10/18/24, 13:39

  15. Benni Mack rebased onto patch set 5 03/23/25, 18:35

  16. core-ci voted on patch set 5 V +1 03/23/25, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76077

  17. Benni Mack commented on patch set 5 CR +1 V +1 03/25/25, 16:11

    Important-104477-RemoveHyphenPrefixFromSys_logsDataFieldEntry.rst:20 Reply

    sys_log? I _hope_ everyone deletes sys log entries after 90 days.... and migrating the sys_log entries for an upgrade is a PITA (I had this with json_decode vs. unserialize already). I'm with skipping this one.
  18. Andreas Kienast commented on patch set 5 03/26/25, 11:05

    Important-104477-RemoveHyphenPrefixFromSys_logsDataFieldEntry.rst:20 Reply

    > I hope everyone deletes sys log entries after 90 days... hahahaha. However, fine with me :).
  19. Andreas Kienast commented on patch set 5 CR -1 03/26/25, 11:08

    Will move the ReST into the correct dir.
  20. Andreas Kienast uploaded patch set 6 CR +1 V +1 03/26/25, 11:10

  21. core-ci voted on patch set 6 V +1 03/26/25, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76368

  22. Andreas Kienast voted on patch set 6 CR +1 V +1 03/26/25, 11:20

  23. Garvin Hicking voted on patch set 6 CR +1 V +1 03/26/25, 13:09

  24. Benni Mack voted on patch set 6 CR +2 V +2 03/26/25, 13:18

  25. Benni Mack merged patch set 7 03/26/25, 13:18