Review main Abandoned

85389[FEATURE] Allow alt-attribute to be used inside core:icon viewhelper

Philipp Kuhlmay CR 0 V 0 Normal +98 −16 updated 04/13/25, 12:05

Commit message

!!! This is a draft at the moment as the JS stuff is not adjusted yet. !!!

This includes the possibility to use an alternative text inside the core:icon Viewhelper.

Example:
<core:icon title="Open actions menu" alt="Menu icon" identifier="module-styleguide" />

The alt-attribute will be rendered inside the img-tag.

Note: This will only be rendered, when there is an img-tag as the output. In some cases (like used in the core), there still might be an svg to be outputted.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 10

Review log 1320

  1. Philipp Kuhlmay uploaded patch set 1 07/26/24, 09:34

  2. Philipp Kuhlmay marked it work in progress 07/26/24, 09:34

  3. Philipp Kuhlmay commented on patch set 1 07/26/24, 09:38

    This change is ready for review.

    IconFactory.php:499 Unresolved

    IMO the title-attribute should be included here too. That's why I made this an array, so other options could be included here in the future. At the moment the title is rendered in the surrounding span-tag, not inside the img-tag itself. But this might be something for another ticket.
  4. core-ci voted on patch set 1 V -1 07/26/24, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62264

  5. Philipp Kuhlmay uploaded patch set 2 V -1 07/26/24, 09:42

  6. core-ci voted on patch set 2 V +1 07/26/24, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62265

  7. Philipp Kuhlmay uploaded patch set 3 V +1 07/26/24, 10:31

  8. Philipp Kuhlmay updated the commit message in patch set 4 07/26/24, 10:34

  9. core-ci voted on patch set 3 V +1 07/26/24, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62266

  10. core-ci voted on patch set 4 V +1 07/26/24, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62267

  11. Andreas Kienast commented on patch set 4 CR -1 07/26/24, 10:42

    This needs adjustments in the JavaScript Icon API as well.
  12. Philipp Kuhlmay uploaded patch set 5 CR -1 V +1 07/26/24, 15:34

  13. Philipp Kuhlmay marked it work in progress 07/26/24, 15:34

  14. core-ci voted on patch set 5 V -1 07/26/24, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62274

  15. Philipp Kuhlmay uploaded patch set 6 V -1 09/06/24, 14:31

  16. Philipp Kuhlmay uploaded patch set 7 09/06/24, 14:36

  17. core-ci voted on patch set 6 V -1 09/06/24, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64974

  18. core-ci voted on patch set 7 V -1 09/06/24, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64976

  19. Chris Müller commented on patch set 7 09/06/24, 15:29

    Feature-104420-AllowAltAttributeInCoreIconViewhelper.rst:14 Unresolved

    IconViewhelper -> IconViewHelper

    Feature-104420-AllowAltAttributeInCoreIconViewhelper.rst:15 Unresolved

    alt text -> alternative text

    Feature-104420-AllowAltAttributeInCoreIconViewhelper.rst:19 Unresolved

    cann -> can alt -> alternative

    Feature-104420-AllowAltAttributeInCoreIconViewhelper.rst:24 Unresolved

    IconViewhelper -> IconViewHelper

    Feature-104420-AllowAltAttributeInCoreIconViewhelper.rst:28 Unresolved

    Please enter an empty line before the code-block for better readability. Also indent one space more.
  20. Benni Mack abandoned the change 04/13/25, 12:05

    abandoned, can be revived later.