85389[FEATURE] Allow alt-attribute to be used inside core:icon viewhelper
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 10
- Build/Sources/TypeScript/backend/element/icon-element.ts+1 −0
- Build/Sources/TypeScript/backend/icons.ts+6 −4
- typo3/sysext/backend/Resources/Public/JavaScript/element/icon-element.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/icons.js+2 −2
- typo3/sysext/core/Classes/Controller/IconController.php+1 −1
- typo3/sysext/core/Classes/Imaging/IconProvider/SvgIconProvider.php+1 −1
- typo3/sysext/core/Classes/Imaging/Icon.php+19 −0
- typo3/sysext/core/Classes/Imaging/IconFactory.php1+5 −3
- typo3/sysext/core/Classes/ViewHelpers/IconViewHelper.php+10 −3
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-104420-AllowAltAttributeInCoreIconViewhelper.rst5new+51 −0
Review log 1320
-
Philipp Kuhlmay uploaded patch set 1 07/26/24, 09:34
-
Philipp Kuhlmay marked it work in progress 07/26/24, 09:34
-
Philipp Kuhlmay commented on patch set 1 07/26/24, 09:38
This change is ready for review.IconFactory.php:499UnresolvedIMO the title-attribute should be included here too. That's why I made this an array, so other options could be included here in the future. At the moment the title is rendered in the surrounding span-tag, not inside the img-tag itself. But this might be something for another ticket. -
core-ci voted on patch set 1 V -1 07/26/24, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62264
-
Philipp Kuhlmay uploaded patch set 2
V -107/26/24, 09:42 -
core-ci voted on patch set 2 V +1 07/26/24, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62265
-
Philipp Kuhlmay uploaded patch set 3
V +107/26/24, 10:31 -
Philipp Kuhlmay updated the commit message in patch set 4 07/26/24, 10:34
-
core-ci voted on patch set 3 V +1 07/26/24, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62266
-
core-ci voted on patch set 4 V +1 07/26/24, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62267
-
Andreas Kienast commented on patch set 4 CR -1 07/26/24, 10:42
This needs adjustments in the JavaScript Icon API as well. -
Philipp Kuhlmay uploaded patch set 5
CR -1V +107/26/24, 15:34 -
Philipp Kuhlmay marked it work in progress 07/26/24, 15:34
-
core-ci voted on patch set 5 V -1 07/26/24, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62274
-
Philipp Kuhlmay uploaded patch set 6
V -109/06/24, 14:31 -
Philipp Kuhlmay uploaded patch set 7 09/06/24, 14:36
-
core-ci voted on patch set 6 V -1 09/06/24, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64974
-
core-ci voted on patch set 7 V -1 09/06/24, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64976
-
Chris Müller commented on patch set 7 09/06/24, 15:29
Feature-104420-AllowAltAttributeInCoreIconViewhelper.rst:14UnresolvedIconViewhelper -> IconViewHelperFeature-104420-AllowAltAttributeInCoreIconViewhelper.rst:15Unresolvedalt text -> alternative textFeature-104420-AllowAltAttributeInCoreIconViewhelper.rst:19Unresolvedcann -> can alt -> alternativeFeature-104420-AllowAltAttributeInCoreIconViewhelper.rst:24UnresolvedIconViewhelper -> IconViewHelperFeature-104420-AllowAltAttributeInCoreIconViewhelper.rst:28UnresolvedPlease enter an empty line before the code-block for better readability. Also indent one space more. -
Benni Mack abandoned the change 04/13/25, 12:05
abandoned, can be revived later.