Review main Merged

85396[BUGFIX] Skip loading fallback icon

Georg Ringer CR +2 V +2 Easy +6 −13 updated 08/06/24, 09:50

Commit message

Since #102834 content elements and plugins are auto registered for the
"New Content Element Wizard" but if no icon is provided, a broken icon
has been shown. To avoid a broken state, the fallback icon is removed.

It is better to show no icon instead of guessing and failing with a
fallback icon.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1624

  1. Georg Ringer uploaded patch set 1 07/27/24, 14:44

  2. Georg Ringer commented on patch set 1 07/27/24, 14:44

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 07/27/24, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62299

  4. Georg Ringer uploaded patch set 2 V -1 07/27/24, 15:33

  5. core-ci voted on patch set 2 V -1 07/27/24, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62301

  6. Georg Ringer uploaded patch set 3 07/27/24, 15:44

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  7. core-ci voted on patch set 3 V -1 07/27/24, 15:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62302

  8. Georg Ringer uploaded patch set 4 V -1 07/27/24, 16:06

  9. core-ci voted on patch set 4 V -1 07/27/24, 16:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62305

  10. Georg Ringer uploaded patch set 5 V -1 07/27/24, 16:23

  11. core-ci voted on patch set 5 V +1 07/27/24, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62307

  12. Christian Kuhn voted on patch set 5 CR +1 V +1 07/30/24, 12:27

  13. Oli Bartsch commented on patch set 5 08/01/24, 19:09

    ExtensionManagementUtility.php:829

    I think we are now missing a `$selectItem->getIcon()` check here now.
  14. Georg Ringer uploaded patch set 6 CR +1 V +1 08/01/24, 19:20

  15. core-ci voted on patch set 6 V -1 08/01/24, 19:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62619

  16. Georg Ringer rebased onto patch set 7 V -1 08/01/24, 19:35

  17. core-ci voted on patch set 7 V +1 08/01/24, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62627

  18. Benni Mack commented on patch set 7 CR +1 08/02/24, 20:12

    ExtensionManagementUtility.php:829 Reply

    I think this is solved now, right?
  19. Christian Kuhn commented on patch set 7 CR +1 V +1 08/06/24, 09:26

    ExtensionManagementUtility.php:829 Reply

    Done
  20. Christian Kuhn uploaded patch set 8 CR +1 V +1 08/06/24, 09:37

  21. Christian Kuhn voted on patch set 8 CR +1 V +1 08/06/24, 09:37

  22. core-ci voted on patch set 8 V +1 08/06/24, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62890

  23. Benni Mack voted on patch set 8 CR +2 V +2 08/06/24, 09:50

  24. Benni Mack merged patch set 9 08/06/24, 09:50