Review main Merged

85397[TASK] Simplify call to RelationHandler with TCA Schema

Benni Mack CR +2 V +2 Normal +71 −57 updated 07/30/24, 12:05

Commit message

Usually, when it comes to resolving related
UIDs, RelationHandler can find the "truth"
for a single relation.

The stone-aged "start()" method is now
wrapped in a better, easier to use method
"initializeForField()"

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1320

  1. Benni Mack uploaded patch set 1 07/27/24, 15:48

  2. core-ci voted on patch set 1 V -1 07/27/24, 15:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62303

  3. Benni Mack uploaded patch set 2 V -1 07/27/24, 16:06

  4. core-ci voted on patch set 2 V -1 07/27/24, 16:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62306

  5. Benni Mack uploaded patch set 3 V -1 07/27/24, 16:45

  6. core-ci voted on patch set 3 V -1 07/27/24, 16:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62308

  7. Benni Mack updated the commit message in patch set 4 V -1 07/27/24, 16:58

  8. core-ci voted on patch set 4 V +1 07/27/24, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62312

  9. Stefan Bürk commented on patch set 4 07/28/24, 19:28

    RelationHandler.php:199

    Should we not check the table workspace state here too ? ``` if (BackendUtility::isTableWorkspaceEnabled($tableName) && ($baseRecordOrUid['t3ver_pid'] ?? 0) > 0) { ```
  10. Oli Bartsch uploaded patch set 5 V +1 07/29/24, 08:12

  11. Oli Bartsch commented on patch set 5 CR +1 V +1 07/29/24, 08:13

    RelationHandler.php:199 Reply

    Done
  12. core-ci voted on patch set 5 V -1 07/29/24, 08:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62363

  13. Oli Bartsch uploaded patch set 6 CR +1 V +1 07/29/24, 08:33

  14. core-ci voted on patch set 6 V -1 07/29/24, 08:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62364

  15. core-ci voted on patch set 6 V +1 07/29/24, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62364

  16. Stefan Bürk voted on patch set 6 CR +1 V +1 07/29/24, 09:19

  17. Christian Kuhn voted on patch set 6 CR -1 07/29/24, 09:47

  18. Christian Kuhn voted on patch set 6 CR +1 V +1 07/30/24, 11:31

  19. Oli Bartsch voted on patch set 6 CR +2 V +2 07/30/24, 12:05

  20. Oli Bartsch merged patch set 7 07/30/24, 12:05