Review main Merged

85399[TASK] Use country API in site_language's flag field

Georg Ringer CR +2 V +2 Hard +62 −271 updated 08/03/24, 11:59

Commit message

Instead of hard-coding all countries, the country API can be used.
The main benefit is now that the name instead of ISO2 of the country is
shown, which is especially useful when dealing with not well-known
countries.

Furthermore, the item groups are used to differ between real countries,
colors and some miscellaneous items.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1826

Show 1 earlier messages
  1. Georg Ringer uploaded patch set 1 07/27/24, 19:01

  1. core-ci voted on patch set 1 V -1 07/27/24, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62318

  2. Georg Ringer uploaded patch set 2 V -1 07/27/24, 19:16

  3. core-ci voted on patch set 2 V -1 07/27/24, 19:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62319

  4. Georg Ringer uploaded patch set 3 V -1 07/31/24, 15:29

  5. core-ci voted on patch set 3 V +1 07/31/24, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62558

  6. Georg Ringer marked it ready for review 08/01/24, 07:21

  7. Georg Ringer marked it work in progress 08/01/24, 07:22

  8. Georg Ringer uploaded patch set 4 V +1 08/01/24, 07:36

  9. Georg Ringer commented on patch set 4 08/01/24, 07:37

    This change is ready for review.
  10. core-ci voted on patch set 4 V +1 08/01/24, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62583

  11. Markus Klein updated the commit message in patch set 5 V +1 08/01/24, 07:53

  12. core-ci voted on patch set 5 V +1 08/01/24, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62585

  13. Markus Klein commented on patch set 5 08/01/24, 09:19

    ItemsProcessorFunctions.php:143

    move this before the loop

    TcaSiteSetCollector.php:42

    unrelated
  14. Markus Klein commented on patch set 6 V +1 08/01/24, 09:20

    Published edit on patch set 5.
  15. Markus Klein commented on patch set 6 08/01/24, 09:20

    ItemsProcessorFunctions.php:143 Reply

    Done

    TcaSiteSetCollector.php:42 Reply

    Done
  16. core-ci voted on patch set 6 V +1 08/01/24, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62587

  17. Markus Klein voted on patch set 6 CR +1 V +1 08/01/24, 09:55

  18. Anja Leichsenring voted on patch set 6 CR +1 V +1 08/01/24, 11:41

  19. Garvin Hicking uploaded patch set 7 CR +1 V +1 08/01/24, 21:23

    Filter languages and re insert EU
  20. Georg Ringer voted on patch set 7 CR +1 V +1 08/01/24, 21:38

  21. core-ci voted on patch set 7 V -1 08/01/24, 21:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62669

  22. core-ci voted on patch set 7 V +1 08/01/24, 22:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62669

  23. Garvin Hicking voted on patch set 7 CR +1 V +1 08/01/24, 22:31

  24. Benni Mack voted on patch set 7 CR +2 V +2 08/03/24, 11:59

  25. Benni Mack merged patch set 8 08/03/24, 11:59