Review main Merged

85400[TASK] Improve test coverage for TagBasedViewHelper

Simon Praetorius CR +2 V +2 Normal +88 −2 updated 07/31/24, 13:28

Commit message

To prevent unintended changes in ViewHelper API in the future,
more test cases are added to TextareaViewHelper as an example
of a TagBasedViewHelper.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1829

Show 24 earlier messages
  1. Simon Praetorius uploaded patch set 1 07/27/24, 21:51

  2. core-ci voted on patch set 1 V -1 07/27/24, 21:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62320

  3. Simon Praetorius uploaded patch set 2 V -1 07/27/24, 22:00

  4. core-ci voted on patch set 2 V -1 07/27/24, 22:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62321

  1. Chris Müller commented on patch set 2 07/28/24, 07:19

    TextareaViewHelperTest.php:75

    This should be "Required is registered ..."
  2. Simon Praetorius uploaded patch set 3 V -1 07/30/24, 11:39

  3. core-ci voted on patch set 3 V -1 07/30/24, 11:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62431

  4. Simon Praetorius uploaded patch set 4 V -1 07/30/24, 13:12

  5. core-ci voted on patch set 4 V -1 07/30/24, 13:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62444

  6. Simon Praetorius uploaded patch set 5 V -1 07/30/24, 14:41

  7. core-ci voted on patch set 5 V -1 07/30/24, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62449

  8. Simon Praetorius uploaded patch set 6 V -1 07/30/24, 15:16

  9. core-ci voted on patch set 6 V -1 07/30/24, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62455

  10. Simon Praetorius uploaded patch set 7 V -1 07/30/24, 15:30

  11. core-ci voted on patch set 7 V -1 07/30/24, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62457

  12. Simon Praetorius uploaded patch set 8 V -1 07/31/24, 09:53

  13. Simon Praetorius commented on patch set 8 07/31/24, 09:54

    This change is ready for review.

    TextareaViewHelperTest.php:75 Reply

    Done
  14. core-ci voted on patch set 8 V -1 07/31/24, 10:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62512

  15. Simon Praetorius rebased onto patch set 9 V -1 07/31/24, 11:16

  16. core-ci voted on patch set 9 V -1 07/31/24, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62522

  17. core-ci voted on patch set 9 V +1 07/31/24, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62522

  18. Christian Kuhn commented on patch set 9 07/31/24, 12:01

    probably main only?!
  19. Simon Praetorius updated the commit message in patch set 10 V +1 07/31/24, 12:19

  20. Christian Kuhn commented on patch set 10 07/31/24, 12:20

    Reply

    Done
  21. Christian Kuhn voted on patch set 10 CR +1 V +1 07/31/24, 12:20

  22. core-ci voted on patch set 10 V +1 07/31/24, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62535

  23. Garvin Hicking voted on patch set 10 CR +1 V +1 07/31/24, 13:27

  24. Simon Praetorius voted on patch set 10 CR +2 V +2 07/31/24, 13:28

  25. Simon Praetorius merged patch set 11 07/31/24, 13:28