85400[TASK] Improve test coverage for TagBasedViewHelper
Commit message
Review
-
Code review CR +2 Done
- Simon Praetorius +2
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Simon Praetorius +2
- Garvin Hicking +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1829
Show 24 earlier messages
-
Simon Praetorius uploaded patch set 1 07/27/24, 21:51
-
core-ci voted on patch set 1 V -1 07/27/24, 21:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62320
-
Simon Praetorius uploaded patch set 2
V -107/27/24, 22:00 -
core-ci voted on patch set 2 V -1 07/27/24, 22:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62321
-
Chris Müller commented on patch set 2 07/28/24, 07:19
-
Simon Praetorius uploaded patch set 3
V -107/30/24, 11:39 -
core-ci voted on patch set 3 V -1 07/30/24, 11:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62431
-
Simon Praetorius uploaded patch set 4
V -107/30/24, 13:12 -
core-ci voted on patch set 4 V -1 07/30/24, 13:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62444
-
Simon Praetorius uploaded patch set 5
V -107/30/24, 14:41 -
core-ci voted on patch set 5 V -1 07/30/24, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62449
-
Simon Praetorius uploaded patch set 6
V -107/30/24, 15:16 -
core-ci voted on patch set 6 V -1 07/30/24, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62455
-
Simon Praetorius uploaded patch set 7
V -107/30/24, 15:30 -
core-ci voted on patch set 7 V -1 07/30/24, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62457
-
Simon Praetorius uploaded patch set 8
V -107/31/24, 09:53 -
Simon Praetorius commented on patch set 8 07/31/24, 09:54
This change is ready for review.TextareaViewHelperTest.php:75ReplyDone -
core-ci voted on patch set 8 V -1 07/31/24, 10:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62512
-
Simon Praetorius rebased onto patch set 9
V -107/31/24, 11:16 -
core-ci voted on patch set 9 V -1 07/31/24, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62522
-
core-ci voted on patch set 9 V +1 07/31/24, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62522
-
Christian Kuhn commented on patch set 9 07/31/24, 12:01
probably main only?! -
Simon Praetorius updated the commit message in patch set 10
V +107/31/24, 12:19 -
Christian Kuhn commented on patch set 10 07/31/24, 12:20
Reply
Done -
Christian Kuhn voted on patch set 10 CR +1 V +1 07/31/24, 12:20
-
core-ci voted on patch set 10 V +1 07/31/24, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62535
-
Garvin Hicking voted on patch set 10 CR +1 V +1 07/31/24, 13:27
-
Simon Praetorius voted on patch set 10 CR +2 V +2 07/31/24, 13:28
-
Simon Praetorius merged patch set 11 07/31/24, 13:28
TextareaViewHelperTest.php:75