Review main Merged

85401[FEATURE] Add `castText()` expression support to `ExpressionBuilder`

Stefan Bürk CR +2 V +2 Normal +241 −9 updated 07/29/24, 15:24

Commit message

To build more advanced database queries enhanced expression
support is required which have been enhanced with  #103309
and #104482 already.

This change jumps onto the ExpressionBuilder enhancement train
and adds the additional `ExpressionBuilder::castText()` method
as preparation to guard recursive common table expressions for
all supported database systems - but there are moste like even
more use-cases for this method.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 79

  1. Stefan Bürk uploaded patch set 1 07/27/24, 23:53

  2. core-ci voted on patch set 1 V -1 07/28/24, 00:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62325

  3. Stefan Bürk uploaded patch set 2 V -1 07/28/24, 01:40

  4. core-ci voted on patch set 2 V +1 07/28/24, 01:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62327

  5. Georg Ringer voted on patch set 2 CR +1 07/28/24, 05:15

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 07/29/24, 13:20

  7. Benni Mack voted on patch set 2 CR +1 V +1 07/29/24, 13:39

  8. Stefan Bürk voted on patch set 2 CR +2 V +2 07/29/24, 15:24

  9. Stefan Bürk merged patch set 3 07/29/24, 15:24