Review main Merged

85402[BUGFIX] Use proper query for specific belog "Delete similar errors"

Garvin Hicking CR +2 V +2 Easy +6 −1 updated 07/30/24, 10:19

Commit message

In case a `sys_log` entry is deleted via the `belog` backend module,
an error was thrown. This only happened for log entries with
`details_nr` 11 or 12 (PHP errors) AND where placeholder values in
the column `details` were used.

Then the backend log module would try to delete all rows only
with the exactly matching, substituted log details, so that not
too many records would be deleted (with different placeholders).

The code for this tried to unserialize the log data, which led
to the created delete-query utilizing an array as named parameter
placeholder value, which then threw an error.

The solution is to use the actual raw data for the query comparison,
which is what this patch does. Then the exact contents of the
fields `details` and `log_data` will be used to delete all
matching rows.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Guido Schmechel +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Garvin Hicking uploaded patch set 1 07/28/24, 08:57

  2. core-ci voted on patch set 1 V +1 07/28/24, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62345

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 07/28/24, 13:05

  4. Guido Schmechel voted on patch set 1 CR +1 07/28/24, 15:45

  5. Nikita Hovratov voted on patch set 1 CR +1 07/29/24, 11:23

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 07/30/24, 10:19

  7. Christian Kuhn merged patch set 2 07/30/24, 10:19