Review main Merged

85412[TASK] Use `f:constant()` with `f:be.infobox`

Andreas Kienast CR +2 V +2 Hard +127 −127 updated 07/30/24, 12:04

Commit message

In Fluid 2.12 a ViewHelper `f:constant()` was introduced for fetching
constant values and enums. This commit updates all usages of
`f:be.infobox` to use its state constants instead of their raw values.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 70

Show 50 more files

Review log 911

  1. Andreas Kienast uploaded patch set 1 07/30/24, 08:37

  2. core-ci voted on patch set 1 V +1 07/30/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62419

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 07/30/24, 09:34

    A lot to sift through, I tested only ony instance and for the rest: * Checked single/double quotes * Checked proper value->constant mappings * Checked no remainders left in code of be.infobox (including short notation); one case is left in a changelog rst, that's IMO fine
  4. Jasmina Ließmann voted on patch set 1 CR +1 V +1 07/30/24, 10:37

  5. Andreas Kienast rebased onto patch set 2 CR +1 V +1 07/30/24, 11:52

  6. Jasmina Ließmann voted on patch set 2 CR +1 V +1 07/30/24, 11:57

  7. Garvin Hicking voted on patch set 2 CR +1 V +1 07/30/24, 11:58

  8. Christian Kuhn voted on patch set 2 CR +1 07/30/24, 12:00

  9. core-ci voted on patch set 2 V +1 07/30/24, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62432

  10. Andreas Kienast voted on patch set 2 CR +2 V +2 07/30/24, 12:04

  11. Andreas Kienast merged patch set 3 07/30/24, 12:04