Review main Merged

85413[DOCS] Properly reflect Fluid "value" resolving in inline comment

Garvin Hicking CR +2 V +2 Easy +2 −2 updated 07/30/24, 12:06

Commit message

If specifying both a "property" and a "value" attribute to a
f:form based Fluid ViewHelper like f:form.textfield, there
is potentially a conflict on which values to use.

It has been discussed that providing a "value" should
have preference over a property value, which is the
current behaviour. However, the inline code comment
did not reflect that.

It is now adjusted to match the actual implementation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Garvin Hicking uploaded patch set 1 07/30/24, 09:40

  2. core-ci voted on patch set 1 V +1 07/30/24, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62421

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 07/30/24, 12:05

  4. Jasmina Ließmann voted on patch set 1 CR +1 V +1 07/30/24, 12:05

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 07/30/24, 12:05

  6. Christian Kuhn merged patch set 2 07/30/24, 12:06