Review main Merged

85416[TASK] Use RecordInterface data in CObjectViewHelper

André Buchmann CR +2 V +2 Easy +2 −1 updated 08/06/24, 12:02

Commit message

Using the RecordTransformationProcessor to fetch content elements
returns objects based on RecordInterface. The interface provides a
toArray() method we can use to access the record data, including the
pi_flexform field. This way, the settings array is also filled with
the flexform data.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. André Buchmann uploaded patch set 1 07/30/24, 13:06

  2. core-ci voted on patch set 1 V +1 07/30/24, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62443

  3. Jochen Roth voted on patch set 1 CR +1 V +1 07/30/24, 17:47

  4. André Buchmann updated the commit message in patch set 2 CR +1 V +1 07/30/24, 17:55

  5. Jochen Roth voted on patch set 2 CR +1 V +1 07/30/24, 17:57

  6. core-ci voted on patch set 2 V +1 07/30/24, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62472

  7. Benni Mack voted on patch set 2 CR +2 V +2 08/06/24, 12:02

  8. Benni Mack merged patch set 3 08/06/24, 12:02