Review main Merged

85439[BUGFIX] Enable inline arrangement of checkboxToggle

Corinne van der Zande CR +2 V +2 Easy +18 −3 updated 08/03/24, 12:38

Commit message

Previously, using the property cols="inline" doesn't have an
effect for checkboxes with renderType checkboxToggle.

This patch resolves this issue and introduces a test case
in typo3/cms-styleguide.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Armin Vieweg +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1216

  1. Corinne van der Zande uploaded patch set 1 08/01/24, 19:01

  2. Corinne van der Zande rebased onto patch set 2 08/01/24, 19:07

  3. core-ci voted on patch set 1 V +1 08/01/24, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62612

  4. Georg Ringer commented on patch set 2 08/01/24, 19:13

    CheckboxToggleElement.php:160

    I suggest something like ---- $inline = ($config['cols'] ?? '') === 'inline'; --- what you think?
  5. core-ci voted on patch set 2 V +1 08/01/24, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62615

  6. Corinne van der Zande uploaded patch set 3 08/01/24, 19:35

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  7. Corinne van der Zande uploaded patch set 4 V +1 08/01/24, 19:37

  8. core-ci voted on patch set 3 V +1 08/01/24, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62626

  9. core-ci voted on patch set 4 V +1 08/01/24, 19:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62628

  10. Armin Vieweg voted on patch set 4 CR +1 08/01/24, 20:14

  11. Corinne van der Zande commented on patch set 4 08/03/24, 12:31

    CheckboxToggleElement.php:160 Reply

    you are right, your suggestion is shorter and more readable. I copied this line from CheckboxLabeledToggleElement::renderSingleCheckboxElement() which is also used in other places. Should we replace these occurences, too? Or is this better done in a separate commit? Thank you for your suggestion. I've just implemented it.
  12. Corinne van der Zande commented on patch set 4 08/03/24, 12:32

    CheckboxToggleElement.php:160 Reply

    Done
  13. Georg Ringer voted on patch set 4 CR +1 V +1 08/03/24, 12:35

  14. Benni Mack voted on patch set 4 CR +1 V +1 08/03/24, 12:37

  15. Georg Ringer voted on patch set 4 CR +2 V +2 08/03/24, 12:38

  16. Georg Ringer merged patch set 5 08/03/24, 12:38