Review main Merged

85442[TASK] Improve tests for form configuration inheritance

Friedemann Altrock CR +2 V +2 Normal +90 −0 updated 08/06/24, 11:38

Commit message

Adds a test that checks for inheritance resolution within numeric
array keys, which are the norm for nested finishers and options.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 913

  1. Friedemann Altrock uploaded patch set 1 08/01/24, 19:33

  2. core-ci voted on patch set 1 V -1 08/01/24, 19:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62623

  3. Friedemann Altrock uploaded patch set 2 V -1 08/01/24, 20:04

  4. core-ci voted on patch set 2 V +1 08/01/24, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62635

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 08/06/24, 11:17

  6. Christian Kuhn updated the commit message in patch set 3 CR +1 V +1 08/06/24, 11:20

  7. Christian Kuhn rebased onto patch set 4 08/06/24, 11:20

  8. Christian Kuhn voted on patch set 4 CR +1 V +1 08/06/24, 11:20

  9. Stefan Bürk voted on patch set 4 CR +1 V +1 08/06/24, 11:20

  10. core-ci voted on patch set 4 V -1 08/06/24, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62908

  11. core-ci voted on patch set 4 V +1 08/06/24, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62908

  12. Christian Kuhn voted on patch set 4 CR +2 V +2 08/06/24, 11:38

  13. Christian Kuhn merged patch set 5 08/06/24, 11:38