85443[BUGFIX] Fix typo in method name isStaticCacheble
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102621-MostTSFEMembersMarkedInternalOrRead-only.rst+1 −0
- typo3/sysext/core/Documentation/Changelog/13.3/Deprecation-104217-TSFEMethodIsStaticCachebleRenamedToIsStaticCacheable.rst2new+37 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+14 −2
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+10 −2
Review log 2128
Show 23 earlier messages
-
Marcel Küpper uploaded patch set 1 08/01/24, 19:40
-
core-ci voted on patch set 1 V +1 08/01/24, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62629
-
Stefan Kapitza-Graetz voted on patch set 1 CR +1 V +1 08/01/24, 19:59
-
Garvin Hicking commented on patch set 1 CR -1 08/01/24, 20:08
We'll change this to a deprecation instead to be non-breaking, on it :) -
Marno Schmigotzki voted on patch set 1 CR +1 08/01/24, 20:15
-
Marno Schmigotzki voted on patch set 1 CR 0 08/01/24, 20:16
-
Marcel Küpper uploaded patch set 2
CR +1V +108/01/24, 21:01 -
core-ci voted on patch set 2 V -1 08/01/24, 21:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62662
-
Georg Ringer uploaded patch set 3
V -108/01/24, 21:36 -
Garvin Hicking updated the commit message in patch set 4 08/01/24, 21:41
Adjust CGL -
core-ci voted on patch set 3 V -1 08/01/24, 21:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62674
-
core-ci voted on patch set 4 V -1 08/01/24, 21:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62676
-
Marcel Küpper uploaded patch set 5
V -108/02/24, 07:08 -
core-ci voted on patch set 5 V -1 08/02/24, 07:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62705
-
Marcel Küpper uploaded patch set 6
V -108/02/24, 08:21 -
core-ci voted on patch set 6 V +1 08/02/24, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62708
-
Garvin Hicking voted on patch set 6 CR +1 V +1 08/02/24, 08:37
-
Garvin Hicking commented on patch set 6 08/02/24, 09:33
Deprecation-104217-TSFEMethodIsStaticCachebleRenamedToIsStaticCacheable.rst:6Georg hinted that we'll need a "speaking" title here, something like: Rename TSFE->... method for proper spelling or so? -
Marcel Küpper uploaded patch set 7
CR +1V +108/02/24, 09:41 -
core-ci voted on patch set 7 V +1 08/02/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62710
-
Stefan Kapitza-Graetz voted on patch set 7 CR +1 V +1 08/02/24, 12:27
-
Georg Ringer voted on patch set 7 CR +1 V +1 08/02/24, 12:34
-
Garvin Hicking voted on patch set 7 CR +1 V +1 08/02/24, 13:01
-
Chris Müller voted on patch set 7 CR +1 08/02/24, 19:52
-
Garvin Hicking commented on patch set 7 08/02/24, 20:17
Deprecation-104217-TSFEMethodIsStaticCachebleRenamedToIsStaticCacheable.rst:6ReplyDone -
Christian Kuhn commented on patch set 7 CR -1 10/08/24, 08:26
Hey. Sorry for having this lying around for so long. I had this patch on my radar, but didn't wanted to act on it since the entire TypoScriptFrontendController is being deprecated, Changing a typo in a method name in a deprecated class is a bit and I think we should avoid the patch. See #105230 for more information on the general deprecation. -
Christian Kuhn commented on patch set 7 10/08/24, 08:35
I will go ahead here and will abandon the patch: There is no good point in fixing a typo in a method from a class that is slated for removal. Consumers need to switch away from the class entirely. -
Christian Kuhn abandoned the change 10/08/24, 08:35