85444[TASK] Instantiate FieldValueGenerators using DI
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 61
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeColor.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeDatetime.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeDatetimeDbTypeDatetime.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeDatetimeFormatDate.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeDatetimeFormatDateDbTypeDate.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeDatetimeFormatTime.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeDatetimeFormatTimesec.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeDatetimeRequiredFormatDate.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeEmail.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeFile.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeFlex.php+14 −5
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeFolder.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeGroupAllowedBeUsers.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeGroupAllowedBeUsersBeGroups.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeGroupAllowedPages.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeGroupAllowedStaticdata.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeGroupAllowedSysFiles.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeGroupFal.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInline1n.php+12 −4
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInlineExpandsingle.php+12 −4
Show 41 more files
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInlineFalSelectSingle12Foreign.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInlineUsecombination.php+12 −4
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInlineUsecombinationGroup.php+12 −4
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInput.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputDynamicTextWithRecordUid.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputEvalAlphanum.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputEvalMd5.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputEvalNum.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputEvalUpper.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputMax4.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputMax4Min4.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeLink.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeNone.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeNoneFormatDateTime.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeNumber.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeNumberFormatDecimal.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypePassthrough.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypePassword.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypePasswordHashedFalse.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeSelectRenderTypeSingleForeignTable.php+12 −4
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeSelectRenderTypeSingleForeignTableForType.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeSelectRenderTypeSingleForeignTableGroupField.php+12 −4
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeText.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeTextDefaultExtrasRichtext.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeTextFormatCodeEditor.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeTextFormatDatetime.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeTextMax30.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeUser.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeUuid.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/TableHandler/General.php+1 −3
- typo3/sysext/styleguide/Classes/TcaDataGenerator/TableHandler/InlineMn.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/TableHandler/InlineMnGroup.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/TableHandler/InlineMnSymmetric.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/TableHandler/InlineMnSymmetricGroup.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/TableHandler/StaticData.php+0 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGeneratorResolver.php+17 −134
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGeneratorResolverAwareInterface.phpnew+29 −0
- typo3/sysext/styleguide/Classes/TcaDataGenerator/Generator.php+3 −18
- typo3/sysext/styleguide/Classes/TcaDataGenerator/RecordData.php+8 −1
- typo3/sysext/styleguide/Classes/TcaDataGenerator/RecordDataAwareInterface.phpnew+41 −0
- typo3/sysext/styleguide/Configuration/Services.yaml2+134 −0
Review log 2852
Show 1527 earlier messages
-
Martin Adler uploaded patch set 1 08/01/24, 19:41
-
core-ci voted on patch set 1 V +1 08/01/24, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62630
-
Martin Adler uploaded patch set 2
V +108/01/24, 22:05 -
Martin Adler uploaded patch set 3 08/01/24, 22:12
-
core-ci voted on patch set 2 V -1 08/01/24, 22:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62684
-
core-ci voted on patch set 3 V -1 08/01/24, 22:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62686
-
Martin Adler uploaded patch set 4
V -108/01/24, 22:27 -
core-ci voted on patch set 4 V +1 08/01/24, 22:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62688
-
Martin Adler uploaded patch set 5
V +108/08/24, 12:34 -
core-ci voted on patch set 5 V +1 08/08/24, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63048
-
Martin Adler uploaded patch set 6 08/08/24, 12:47
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
Martin Adler uploaded patch set 7
V +108/08/24, 12:54 -
Martin Adler uploaded patch set 8 08/08/24, 12:57
-
core-ci voted on patch set 6 V -1 08/08/24, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63051
-
core-ci voted on patch set 7 V +1 08/08/24, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63052
-
core-ci voted on patch set 6 V +1 08/08/24, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63051
-
core-ci voted on patch set 8 V +1 08/08/24, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63053
-
Martin Adler uploaded patch set 9
V +108/08/24, 18:58 -
core-ci voted on patch set 9 V +1 08/08/24, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63083
-
Martin Adler updated the commit message in patch set 10
V +108/08/24, 19:17 -
Martin Adler updated the commit message in patch set 11 08/08/24, 19:18
-
core-ci voted on patch set 11 V +1 08/08/24, 19:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63088
-
core-ci voted on patch set 10 V +1 08/08/24, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63087
-
Martin Adler marked it ready for review 08/08/24, 19:28
-
Martin Adler marked it work in progress 08/08/24, 19:53
-
Martin Adler marked it ready for review 08/15/24, 09:40
-
Martin Adler updated the commit message in patch set 12
V +108/15/24, 09:40
-
core-ci voted on patch set 12 V -1 08/15/24, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63462
-
core-ci commented on patch set 12 08/15/24, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63462
-
core-ci commented on patch set 12 08/15/24, 10:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63462
-
Martin Adler rebased onto patch set 13
V -108/15/24, 10:08 -
core-ci voted on patch set 13 V -1 08/15/24, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63467
-
core-ci commented on patch set 13 08/15/24, 10:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63467
-
Martin Adler rebased onto patch set 14
V -108/15/24, 12:27 -
core-ci voted on patch set 14 V +1 08/15/24, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63479
-
Christian Kuhn commented on patch set 14 CR -1 08/20/24, 08:59
Services.yaml:16this resorts in comparison to the previous solution: general is now 'first' and always kicks in. -
Martin Adler rebased onto patch set 15
CR -1V +109/17/24, 12:49 -
core-ci voted on patch set 15 V +1 09/17/24, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66015
-
Christian Kuhn uploaded patch set 16
V +109/19/24, 20:50 -
Christian Kuhn commented on patch set 15 09/19/24, 20:50
Services.yaml:16ReplyDone -
core-ci voted on patch set 16 V -1 09/19/24, 20:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66254
-
Christian Kuhn uploaded patch set 17
V -109/19/24, 21:15 -
Christian Kuhn updated the commit message in patch set 18 09/19/24, 21:18
-
core-ci voted on patch set 17 V +1 09/19/24, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66255
-
core-ci voted on patch set 18 V +1 09/19/24, 21:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66256
-
Christian Kuhn uploaded patch set 19
V +109/19/24, 21:25 -
Christian Kuhn uploaded patch set 20 09/19/24, 21:28
-
core-ci voted on patch set 19 V +1 09/19/24, 21:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66257
-
core-ci voted on patch set 20 V +1 09/19/24, 21:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66258
-
Christian Kuhn voted on patch set 20 CR +1 V +1 09/19/24, 21:40
-
Stefan Bürk voted on patch set 20 CR +2 V +2 09/20/24, 09:46
-
Stefan Bürk merged patch set 21 09/20/24, 09:46