Review main Merged

85444[TASK] Instantiate FieldValueGenerators using DI

Martin Adler CR +2 V +2 Hard +319 −279 updated 09/20/24, 09:46

Commit message

This patch seeks to inject a list of all FieldGenerators instances
in EXT:styleguide instead of creating them using GU::makeInstance()
each time.

To achieve this, the class list is moved from a class property
to a constructor argument in the `Services.yaml`, reverting the
public exposure of the many Generators in the DI container.

This leads to circular dependencies where data generators need
instances of RecordData or FieldGeneratorResolver again. This
is resolved with two new interfaces to set these instances at
runtime.

TableHandler implementations follow the same pattern.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 61

Show 41 more files

Review log 2852

Show 1527 earlier messages
  1. Martin Adler uploaded patch set 1 08/01/24, 19:41

  2. core-ci voted on patch set 1 V +1 08/01/24, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62630

  3. Martin Adler uploaded patch set 2 V +1 08/01/24, 22:05

  4. Martin Adler uploaded patch set 3 08/01/24, 22:12

  5. core-ci voted on patch set 2 V -1 08/01/24, 22:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62684

  6. core-ci voted on patch set 3 V -1 08/01/24, 22:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62686

  7. Martin Adler uploaded patch set 4 V -1 08/01/24, 22:27

  8. core-ci voted on patch set 4 V +1 08/01/24, 22:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62688

  9. Martin Adler uploaded patch set 5 V +1 08/08/24, 12:34

  10. core-ci voted on patch set 5 V +1 08/08/24, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63048

  11. Martin Adler uploaded patch set 6 08/08/24, 12:47

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  12. Martin Adler uploaded patch set 7 V +1 08/08/24, 12:54

  13. Martin Adler uploaded patch set 8 08/08/24, 12:57

  14. core-ci voted on patch set 6 V -1 08/08/24, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63051

  15. core-ci voted on patch set 7 V +1 08/08/24, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63052

  16. core-ci voted on patch set 6 V +1 08/08/24, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63051

  17. core-ci voted on patch set 8 V +1 08/08/24, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63053

  18. Martin Adler uploaded patch set 9 V +1 08/08/24, 18:58

  19. core-ci voted on patch set 9 V +1 08/08/24, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63083

  20. Martin Adler updated the commit message in patch set 10 V +1 08/08/24, 19:17

  21. Martin Adler updated the commit message in patch set 11 08/08/24, 19:18

  22. core-ci voted on patch set 11 V +1 08/08/24, 19:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63088

  23. core-ci voted on patch set 10 V +1 08/08/24, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63087

  24. Martin Adler marked it ready for review 08/08/24, 19:28

  25. Martin Adler marked it work in progress 08/08/24, 19:53

  26. Martin Adler marked it ready for review 08/15/24, 09:40

  27. Martin Adler updated the commit message in patch set 12 V +1 08/15/24, 09:40

  1. core-ci voted on patch set 12 V -1 08/15/24, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63462

  2. core-ci commented on patch set 12 08/15/24, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63462

  3. core-ci commented on patch set 12 08/15/24, 10:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63462

  4. Martin Adler rebased onto patch set 13 V -1 08/15/24, 10:08

  5. core-ci voted on patch set 13 V -1 08/15/24, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63467

  6. core-ci commented on patch set 13 08/15/24, 10:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63467

  7. Martin Adler rebased onto patch set 14 V -1 08/15/24, 12:27

  8. core-ci voted on patch set 14 V +1 08/15/24, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63479

  9. Christian Kuhn commented on patch set 14 CR -1 08/20/24, 08:59

    Services.yaml:16

    this resorts in comparison to the previous solution: general is now 'first' and always kicks in.
  10. Martin Adler rebased onto patch set 15 CR -1 V +1 09/17/24, 12:49

  11. core-ci voted on patch set 15 V +1 09/17/24, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66015

  12. Christian Kuhn uploaded patch set 16 V +1 09/19/24, 20:50

  13. Christian Kuhn commented on patch set 15 09/19/24, 20:50

    Services.yaml:16 Reply

    Done
  14. core-ci voted on patch set 16 V -1 09/19/24, 20:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66254

  15. Christian Kuhn uploaded patch set 17 V -1 09/19/24, 21:15

  16. Christian Kuhn updated the commit message in patch set 18 09/19/24, 21:18

  17. core-ci voted on patch set 17 V +1 09/19/24, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66255

  18. core-ci voted on patch set 18 V +1 09/19/24, 21:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66256

  19. Christian Kuhn uploaded patch set 19 V +1 09/19/24, 21:25

  20. Christian Kuhn uploaded patch set 20 09/19/24, 21:28

  21. core-ci voted on patch set 19 V +1 09/19/24, 21:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66257

  22. core-ci voted on patch set 20 V +1 09/19/24, 21:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66258

  23. Christian Kuhn voted on patch set 20 CR +1 V +1 09/19/24, 21:40

  24. Stefan Bürk voted on patch set 20 CR +2 V +2 09/20/24, 09:46

  25. Stefan Bürk merged patch set 21 09/20/24, 09:46