Review main Merged

85449[BUGFIX] Provide uploaded files as extbase arguments

Daniel Goerz CR +2 V +2 Easy +12 −7 updated 08/02/24, 07:32

Commit message

This patch enables property mapping of PSR-7
UploadedFile objects to DTO properties.

The workaround for this bug in EXT:form is reverted,
because it is not needed anymore.

Also, a previously broken argument naming for uploaded
files triggers a dedicated exception now.

Finally, the UploadedFile implementation of TYPO3 is
no longer marked as @internal, as it is now exposed to
extbase property mapping.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Benni Mack +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Benni Mack +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Daniel Goerz uploaded patch set 1 08/01/24, 20:32

  2. Georg Ringer commented on patch set 1 08/01/24, 20:37

    please also take a look at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83749 or maybe talk to torben as he is really into this topic
  3. core-ci voted on patch set 1 V +1 08/01/24, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62650

  4. Daniel Goerz commented on patch set 1 08/01/24, 20:54

    Reply

    He was/is involved 😊
  5. Daniel Goerz updated the commit message in patch set 2 V +1 08/01/24, 21:03

  6. Torben Hansen voted on patch set 2 CR +1 V +1 08/01/24, 21:04

  7. core-ci voted on patch set 2 V +1 08/01/24, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62663

  8. Helmut Hummel voted on patch set 2 CR +2 V +2 08/02/24, 06:01

  9. Benni Mack commented on patch set 2 08/02/24, 07:31

    RequestBuilder.php:135

    any reason you use array_merge_recursive over array_replace_recursive?
  10. Benni Mack commented on patch set 2 CR +2 V +2 08/02/24, 07:32

    RequestBuilder.php:135 Reply

    OK. nevermind, it was already done so in EXT:form
  11. Benni Mack merged patch set 3 08/02/24, 07:32