Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
85450[FEATURE] Add PSR-14 events for augmenting and restoring page cache data
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 14
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/50/85450/14 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/50/85450/14 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -1 Needs a vote
- Georg Ringer -1
- Sascha Nowak +1
- Simon Schaufelberger -1
-
Verified V -1 Blocked
- Sascha Nowak +1
- Simon Schaufelberger -1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-104529-PSR14EventsForAddingAndRestoringAdditionalPageCacheData.rst2new+75 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php1+27 −4
- typo3/sysext/frontend/Classes/Event/AfterCachedPageIsLoadedEvent.phpnew+63 −0
- typo3/sysext/frontend/Classes/Event/BeforeCachedPageIsPersistedEvent.phpnew+65 −0
- typo3/sysext/frontend/Classes/Middleware/PrepareTypoScriptFrontendRendering.php+7 −0
Review log 3246
Show 1421 earlier messages
-
Tim Weisenberger uploaded patch set 1 08/01/24, 20:46
-
core-ci voted on patch set 1 V +1 08/01/24, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62655
-
Stefan Bürk commented on patch set 1 08/01/24, 22:00
I'd say we should not introduce hooks anymore and better user a PSR-14 event. Beside that, FEATURES are main only and also needs a corresponding feature rst file describing the event. Testing the events should also be included (that they are dispatched and the added data can really be added to the cache. -
Tim Weisenberger uploaded patch set 2
V +108/21/24, 12:43 -
core-ci voted on patch set 2 V -1 08/21/24, 12:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63909
-
Tim Weisenberger uploaded patch set 3
V -108/21/24, 12:55 -
core-ci voted on patch set 3 V -1 08/21/24, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63912
-
Tim Weisenberger uploaded patch set 4
V -109/16/24, 16:10 -
core-ci voted on patch set 4 V -1 09/16/24, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65908
-
Tim Weisenberger uploaded patch set 5
V -109/16/24, 16:28 -
Tim Weisenberger commented on patch set 5 09/16/24, 16:31
Reply
Thanks for your feedback. I pushed a new patchset which implements the same functionality based on a PSR-14 event. I also tried to add tests for the event in the TypoScriptFrontendController, but the event can only be tested with a lot of mocking effort, as there is no direct access to the method. I have also noticed that many of the recent patches for PSR-14 events do not include any tests. Therefore my question is if a test is really essential for this patch? -
Sascha Nowak voted on patch set 5 CR +1 09/16/24, 16:34
-
Tim Weisenberger uploaded patch set 6
CR +109/16/24, 16:37 -
core-ci voted on patch set 5 V -1 09/16/24, 16:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65912
-
core-ci voted on patch set 6 V +1 09/16/24, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65913
-
Sascha Nowak voted on patch set 6 CR +1 09/16/24, 16:55
-
Sascha Nowak uploaded patch set 7
CR +1V +112/06/24, 15:48 -
Sascha Nowak voted on patch set 7 CR +1 V +1 12/06/24, 15:48
-
core-ci voted on patch set 7 V +1 12/06/24, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70715
-
Sascha Nowak commented on patch set 7 12/06/24, 16:15
Reply
Acknowledged -
Simon Schaufelberger uploaded patch set 8
CR +1V +112/07/24, 13:45
-
core-ci voted on patch set 8 V +1 12/07/24, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70745
-
Sascha Nowak voted on patch set 8 CR +1 V +1 12/10/24, 10:36
-
Christian Kuhn commented on patch set 8 CR -1 12/10/24, 12:05
i would like to postpone this feature until tsfe is gone, to see if we still need it then: its possible these events are not needed anymore and could be middlewares. -
Benni Mack commented on patch set 8 12/10/24, 18:42
we previously used AfterCacheableContentIsGeneratedEvent for that. -
Sascha Nowak uploaded patch set 9
CR +1V +108/18/25, 17:31 -
core-ci voted on patch set 9 V -1 08/18/25, 17:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83576
-
Sascha Nowak uploaded patch set 10
V -108/18/25, 17:59 -
core-ci voted on patch set 10 V +1 08/18/25, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83577
-
Jan Delius commented on patch set 10 V +1 09/26/25, 14:03
Feature-104529-IntroducePSR14EventPageCacheRecord.rst:23I don't know why gerrit shows that so strange. When downloading this patch via git, the rst looks correctFeature-104529-IntroducePSR14EventPageCacheRecord.rst:37I think we don't need this argument hereFeature-104529-IntroducePSR14EventPageCacheRecord.rst:56I think we don't need this argument here -
Tim Weisenberger uploaded patch set 11
V +111/08/25, 14:51 -
Tim Weisenberger uploaded patch set 12 11/08/25, 14:55
-
Tim Weisenberger uploaded patch set 13 11/08/25, 15:01
-
core-ci voted on patch set 11 V +1 11/08/25, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88702
-
Tim Weisenberger commented on patch set 13 11/08/25, 15:04
Feature-104529-IntroducePSR14EventPageCacheRecord.rst:23ReplyIt was also broken in git, but now it is fixed. Thanks.Feature-104529-IntroducePSR14EventPageCacheRecord.rst:37ReplyGood point, done.Feature-104529-IntroducePSR14EventPageCacheRecord.rst:56ReplyGood point, done. -
core-ci voted on patch set 12 V +1 11/08/25, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88703
-
core-ci voted on patch set 13 V +1 11/08/25, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88704
-
Simon Schaufelberger commented on patch set 13 11/08/25, 15:15
Feature-104529-PSR14EventsForAddingAndRestoringAdditionalPageCacheData.rst:23remove trailing whitespace. maybe wrong configuration in your ide? -
Tim Weisenberger uploaded patch set 14
V +111/08/25, 19:36 -
core-ci voted on patch set 14 V +1 11/08/25, 19:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88714
-
Simon Schaufelberger commented on patch set 14 CR +1 V +1 11/08/25, 19:52
Feature-104529-PSR14EventsForAddingAndRestoringAdditionalPageCacheData.rst:23ReplyDone -
Sascha Nowak voted on patch set 14 CR +1 V +1 11/08/25, 20:31
-
Simon Schaufelberger commented on patch set 14 CR -1 V -1 11/29/25, 11:44
TypoScriptFrontendController.php:127UnresolvedTSFE is gone, this needs bigger refactoring -
Georg Ringer commented on patch set 14 CR -1 03/15/26, 07:54
code is still the same in typo3/sysext/frontend/Classes/Http/RequestHandler.php but IMO the current AfterCachedPageIsPersistedEvent is perfectly fine for also modifying the data?! -
Benni Mack wrote 04/21/26, 14:51
Removed cc Benni Mack. -
Christian Kuhn wrote 06/18/26, 23:06
Removed reviewer Christian Kuhn.