Review main Abandoned

85474[BUGFIX] Avoid zipping of a single download file

Marc Willmann CR 0 V 0 Easy +24 −0 updated 01/24/25, 07:16

Commit message

When downloading a file from the Listview using the download button, the
zip file has to be generated only if more than one file is used. For a
single file, this is not only superfluous, but may break the download
completely for e.g. large files, which needs to long to zip in an
archive.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1216

  1. Marc Willmann uploaded patch set 1 08/01/24, 21:10

  2. core-ci voted on patch set 1 V -1 08/01/24, 21:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62665

  3. Marc Willmann rebased onto patch set 2 V -1 08/02/24, 19:49

  4. core-ci voted on patch set 2 V -1 08/02/24, 19:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62765

  5. Marc Willmann uploaded patch set 3 V -1 08/02/24, 19:57

  6. core-ci voted on patch set 3 V +1 08/02/24, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62767

  7. Simon Schaufelberger voted on patch set 3 CR +1 08/06/24, 05:30

  8. Simon Schaufelberger uploaded patch set 4 CR +1 V +1 08/06/24, 09:47

  9. Simon Schaufelberger commented on patch set 4 08/06/24, 09:49

    FileDownloadController.php:85 Unresolved

    I'm getting a warning in phpstorm that this foreach does not loop. Can we instead get the first array key/value and then continue?
  10. core-ci voted on patch set 4 V +1 08/06/24, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62891

  11. Benni Mack commented on patch set 4 01/22/25, 10:06

    I think this needs to be solved on a different level... if the "Download" button is hit, and only one file is selected, we should trigger the native logic like the "download" attribute.
  12. Benni Mack voted on patch set 4 CR -1 01/22/25, 10:07

  13. Andreas Kienast commented on patch set 4 01/22/25, 11:07

    Reply Unresolved

    This may not work here for several reasons: * the trigger is a button element, `download` works on anchors only * this requires that the file is either publicly available which may not be the case for e.g. remote storages, or that the file content is known beforehand
  14. Andreas Kienast commented on patch set 4 CR -1 01/22/25, 12:32

    Unresolved

    On it
  15. Andreas Kienast commented on patch set 4 01/22/25, 12:45

    Unresolved

  16. Andreas Kienast abandoned the change 01/24/25, 07:16

    The alternative approach solving this issue has been merged. Thank you very much for your take on this.