85474[BUGFIX] Avoid zipping of a single download file
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1216
-
Marc Willmann uploaded patch set 1 08/01/24, 21:10
-
core-ci voted on patch set 1 V -1 08/01/24, 21:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62665
-
Marc Willmann rebased onto patch set 2
V -108/02/24, 19:49 -
core-ci voted on patch set 2 V -1 08/02/24, 19:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62765
-
Marc Willmann uploaded patch set 3
V -108/02/24, 19:57 -
core-ci voted on patch set 3 V +1 08/02/24, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62767
-
Simon Schaufelberger voted on patch set 3 CR +1 08/06/24, 05:30
-
Simon Schaufelberger uploaded patch set 4
CR +1V +108/06/24, 09:47 -
Simon Schaufelberger commented on patch set 4 08/06/24, 09:49
-
core-ci voted on patch set 4 V +1 08/06/24, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62891
-
Benni Mack commented on patch set 4 01/22/25, 10:06
I think this needs to be solved on a different level... if the "Download" button is hit, and only one file is selected, we should trigger the native logic like the "download" attribute. -
Benni Mack voted on patch set 4 CR -1 01/22/25, 10:07
-
Andreas Kienast commented on patch set 4 01/22/25, 11:07
Reply Unresolved
This may not work here for several reasons: * the trigger is a button element, `download` works on anchors only * this requires that the file is either publicly available which may not be the case for e.g. remote storages, or that the file content is known beforehand -
Andreas Kienast commented on patch set 4 CR -1 01/22/25, 12:32
Unresolved
On it -
Andreas Kienast commented on patch set 4 01/22/25, 12:45
Unresolved
Pushed an alternative approach to https://review.typo3.org/c/Packages/TYPO3.CMS/+/87853 -
Andreas Kienast abandoned the change 01/24/25, 07:16
The alternative approach solving this issue has been merged. Thank you very much for your take on this.
FileDownloadController.php:85Unresolved