Review main Merged

85481[TASK] Use more DI attributes in ext:core

Alexander M. Turek CR +2 V +2 Normal +44 −78 updated 08/09/24, 16:04

Commit message

Use Symfony DI attribute AsAlias, AutoconfigureTag, Autowire and
AutowireLocator were applicable in ext:core in order to have class
and service definition centralized in the class file.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 69

  1. Alexander M. Turek uploaded patch set 1 08/01/24, 21:55

  2. Alexander M. Turek uploaded patch set 2 08/01/24, 22:04

  3. core-ci voted on patch set 1 V -1 08/01/24, 22:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62681

  4. core-ci voted on patch set 2 V +1 08/01/24, 22:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62683

  5. Benjamin Franzke uploaded patch set 3 V +1 08/09/24, 11:39

  6. Benjamin Franzke commented on patch set 3 CR +1 V +1 08/09/24, 11:42

    AsCommand.php:23

    I'd like to keep this attribute out of this patch, as it needs to be discussed separately (disclaimer: I was against it, when we discussed this during the introduction of AsCommand – and I am still thinking `schedulable` is not worth a separate attribute, as it's a specific `EXT:scheduler` attribute and not a general command-attribute.) I didn't just wanted to remove your code, so I moved it into https://review.typo3.org/c/Packages/TYPO3.CMS/+/85571
  7. core-ci voted on patch set 3 V +1 08/09/24, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63133

  8. Benni Mack commented on patch set 3 CR +2 V +2 08/09/24, 16:04

    Thanks!
  9. Benni Mack merged patch set 4 08/09/24, 16:04