Review main Merged

85483[TASK] Make workspace HistoryService stateless

Anja Leichsenring CR +2 V +2 Easy +14 −35 updated 08/05/24, 09:07

Commit message

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1316

  1. Anja Leichsenring uploaded patch set 1 08/02/24, 07:12

  2. Anja Leichsenring commented on patch set 1 08/02/24, 07:13

    this is the reconstruction of the reverted patch by Martin Adler. All credits to him. https://review.typo3.org/c/Packages/TYPO3.CMS/+/85111
  3. core-ci voted on patch set 1 V +1 08/02/24, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62706

  4. Georg Ringer voted on patch set 1 CR +1 V +1 08/02/24, 07:23

  5. Nikita Hovratov uploaded patch set 2 CR +1 V +1 08/02/24, 10:40

  6. Nikita Hovratov voted on patch set 2 CR +1 V +1 08/02/24, 10:40

  7. core-ci voted on patch set 2 V +1 08/02/24, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62718

  8. Anja Leichsenring commented on patch set 2 08/02/24, 16:55

    Reply

    Andreas Nedbal is the one. Sorry, so sorry, mixed things up again ...
  9. Garvin Hicking commented on patch set 2 CR +1 V +1 08/02/24, 22:04

    HistoryService.php:33

    Could this be a readonly class then directly?
  10. Christian Kuhn commented on patch set 2 08/03/24, 08:36

    HistoryService.php:33 Reply

    yes please
  11. Georg Ringer uploaded patch set 3 CR +1 V +1 08/03/24, 09:15

  12. core-ci voted on patch set 3 V +1 08/03/24, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62792

  13. Georg Ringer voted on patch set 3 CR +1 V +1 08/03/24, 12:56

  14. Christian Kuhn commented on patch set 3 CR +1 V +1 08/05/24, 09:02

    HistoryService.php:33 Reply

    Done
  15. Anja Leichsenring voted on patch set 3 CR +2 V +2 08/05/24, 09:07

  16. Anja Leichsenring merged patch set 4 08/05/24, 09:07