Review main Merged

85484[BUGFIX] Set current phpstan release conflicting

Anja Leichsenring CR +2 V +2 Easy +2 −2 updated 08/02/24, 14:23

Commit message

Used command:

	composer require --dev phpstan/phpstan:"^1.11.8, !=1.11.9"

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Markus Klein +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Markus Klein +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1317

  1. Anja Leichsenring uploaded patch set 1 08/02/24, 08:33

  2. Anja Leichsenring commented on patch set 1 08/02/24, 08:34

    according to Markus Klein, who conducted the research on this failure, no source of the offending regex (see forge ticket) could be found. Someone else might have insights, whether maybe phpstan might be in the wrong here? Anyway, adding the error to baseline gets us back to green status, so it is an acceptable solution for now.
  3. Markus Klein voted on patch set 1 CR +1 V +1 08/02/24, 08:37

  4. core-ci voted on patch set 1 V +1 08/02/24, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62709

  5. Andreas Wolf commented on patch set 1 08/02/24, 08:42

  6. Markus Klein commented on patch set 1 CR -1 V -1 08/02/24, 10:53

    let's declare a conflict with 1.11.9 instead
  7. Anja Leichsenring uploaded patch set 2 CR -1 V +1 08/02/24, 11:48

  8. core-ci voted on patch set 2 V +1 08/02/24, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62724

  9. Markus Klein voted on patch set 2 CR +1 V +1 08/02/24, 14:05

  10. Anja Leichsenring uploaded patch set 3 CR +1 V +1 08/02/24, 14:10

  11. Anja Leichsenring uploaded patch set 4 08/02/24, 14:11

  12. core-ci voted on patch set 3 V +1 08/02/24, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62740

  13. Markus Klein voted on patch set 4 CR +1 V +1 08/02/24, 14:18

  14. Christian Kuhn voted on patch set 4 CR +1 V +1 08/02/24, 14:22

  15. core-ci voted on patch set 4 V +1 08/02/24, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62741

  16. Anja Leichsenring voted on patch set 4 CR +2 V +2 08/02/24, 14:23

  17. Anja Leichsenring merged patch set 5 08/02/24, 14:23