85485[FEATURE] Provide validators for PSR-7 UploadedFile objects in Extbase
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Goerz +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 14
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-104526-ProvideValidatorsForPSR-7UploadedFileObjectsInExtbase.rstnew+79 −0
- typo3/sysext/extbase/Classes/Error/Result.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractValidator.php+24 −0
- typo3/sysext/extbase/Classes/Validation/Validator/FileNameValidator.phpnew+64 −0
- typo3/sysext/extbase/Classes/Validation/Validator/FileSizeValidator.phpnew+117 −0
- typo3/sysext/extbase/Classes/Validation/Validator/ImageDimensionsValidator.phpnew+182 −0
- typo3/sysext/extbase/Classes/Validation/Validator/MimeTypeValidator.phpnew+120 −0
- typo3/sysext/extbase/Resources/Private/Language/locallang.xlf+33 −0
- typo3/sysext/extbase/Tests/Functional/Validation/Fixtures/image-900x382.pngnewbinary
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/AbstractUploadedFileTestCase.phpnew+59 −0
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/FileNameValidatorTest.phpnew+82 −0
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/FileSizeValidatorTest.phpnew+120 −0
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/ImageDimensionsValidatorTest.phpnew+179 −0
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/MimeTypeValidatorTest.phpnew+167 −0
Review log 1927
Show 12 earlier messages
-
Torben Hansen uploaded patch set 1 08/02/24, 09:43
-
core-ci voted on patch set 1 V +1 08/02/24, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62711
-
Mathias Brodala commented on patch set 1 08/02/24, 10:12
-
Torben Hansen uploaded patch set 2
V +108/02/24, 12:58 -
Torben Hansen commented on patch set 2 08/02/24, 12:59
DenyPhpUploadValidator.php:27ReplyDone -
core-ci voted on patch set 2 V +1 08/02/24, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62729
-
Mathias Brodala commented on patch set 2 08/02/24, 13:08
DenyPhpUploadValidatorTest.php:25Can you also update this one to match its SUT? ;-) -
Torben Hansen uploaded patch set 3
V +108/02/24, 17:43 -
Torben Hansen commented on patch set 2 08/02/24, 17:44
DenyPhpUploadValidatorTest.php:25ReplyDone -
core-ci voted on patch set 3 V +1 08/02/24, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62762
-
Torben Hansen uploaded patch set 4
V +108/04/24, 06:41 -
core-ci voted on patch set 4 V +1 08/04/24, 06:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62820
-
Torben Hansen marked it work in progress 08/04/24, 09:24
-
Torben Hansen uploaded patch set 5
V +108/04/24, 11:01 -
Torben Hansen marked it ready for review 08/04/24, 11:02
-
core-ci voted on patch set 5 V -1 08/04/24, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62826
-
Torben Hansen uploaded patch set 6
V -108/04/24, 11:21 -
core-ci voted on patch set 6 V +1 08/04/24, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62827
-
Daniel Goerz commented on patch set 7
V +108/06/24, 09:14Published edit on patch set 6. -
core-ci voted on patch set 7 V +1 08/06/24, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62887
-
Daniel Goerz commented on patch set 7 CR +1 08/06/24, 09:21
While I'd rather see the validators work for the PSR-7 interface I do not see a good way to make that work as the interface does not allow access to the file before it has been moved. Will also test the patch when I find the time ... -
Torben Hansen uploaded patch set 8
CR +1V +108/06/24, 09:33 -
core-ci voted on patch set 8 V +1 08/06/24, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62889
-
Daniel Goerz voted on patch set 8 CR +1 08/06/24, 09:39
-
Christian Kuhn voted on patch set 8 CR +1 V +1 08/06/24, 09:50
-
Benni Mack voted on patch set 8 CR +2 V +2 08/06/24, 12:01
-
Benni Mack merged patch set 9 08/06/24, 12:01
DenyPhpUploadValidator.php:27