Review main Merged

85489[TASK] Dynamically limit livesearch to searchFields used in subtypes

Kevin Appelt CR +2 V +2 Hard +259 −17 updated 02/07/25, 22:19

Commit message

Previously, the bodytext field, for example, was only searched
if the CType was text, textpic or textmedia. This condition is
unknown to practically all developers which has been spoken to.
The only exception so far seems to be the `EXT:mask` extension,
which already dynamically extends this condition.

It was introduced with TYPO3 v4.6 with #26829 and was pretty
much untouched ever since.

With the introduction of the TCA Schema API, we can handle the
issue much more generically for all tables with subtypes. We
can thus make the search much more precise and only search in
fields that actually exist in the respective subtype like the
CType for example.

The purpose of this search restriction is to ensure that, for
example, the content in the bodytext field is no longer found
if it was filled as a text element and then changed to a plugin.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1625

  1. Kevin Appelt uploaded patch set 1 08/02/24, 12:26

  2. core-ci voted on patch set 1 V -1 08/02/24, 12:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62728

  3. Benni Mack uploaded patch set 2 V -1 01/31/25, 22:56

  4. core-ci voted on patch set 2 V -1 01/31/25, 23:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73295

  5. Benni Mack uploaded patch set 3 V -1 01/31/25, 23:55

  6. core-ci voted on patch set 3 V +1 02/01/25, 00:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73296

  7. Benni Mack voted on patch set 3 CR +1 V +1 02/01/25, 20:13

  8. Benni Mack uploaded patch set 4 CR +1 V +1 02/07/25, 13:44

  9. Stefan Bürk voted on patch set 4 CR -1 02/07/25, 13:55

  10. core-ci voted on patch set 4 V -1 02/07/25, 13:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73731

  11. Stefan Bürk commented on patch set 4 02/07/25, 14:02

    Some details needs to be sorted out, on it ...
  12. Stefan Bürk uploaded patch set 5 CR -1 V -1 02/07/25, 15:55

  13. core-ci voted on patch set 5 V +1 02/07/25, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73750

  14. Stefan Bürk uploaded patch set 6 V +1 02/07/25, 18:11

  15. Stefan Bürk commented on patch set 6 02/07/25, 18:12

    Reply

    Technically sorted out, streamlined and tested. Only question is duplicated code should be directly centralized at one place. See code comment(s) and commit message.
  16. core-ci voted on patch set 6 V -1 02/07/25, 18:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73758

  17. Stefan Bürk uploaded patch set 7 V -1 02/07/25, 18:21

  18. core-ci voted on patch set 7 V +1 02/07/25, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73759

  19. core-ci commented on patch set 7 02/07/25, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73761

  20. Stefan Bürk updated the commit message in patch set 8 V +1 02/07/25, 21:50

  21. Stefan Bürk commented on patch set 8 02/07/25, 21:50

    Reply

    Done
  22. Stefan Bürk voted on patch set 8 CR +1 V +1 02/07/25, 21:50

  23. core-ci voted on patch set 8 V +1 02/07/25, 21:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73775

  24. Benni Mack voted on patch set 8 CR +2 V +2 02/07/25, 22:19

  25. Benni Mack merged patch set 9 02/07/25, 22:19