Review main Merged

85490[BUGFIX] Fix PID evaluation for nested Extbase objects on creation

Torben Hansen CR +2 V +2 Normal +125 −1 updated 08/06/24, 08:24

Commit message

When a new object is persisted in extbase, the target page uid of the
object is determined either from the `persistence.storagePid` or the
`persistence.classes.<className>.newRecordStoragePid` TypoScript
configuration. This works well for top level domain objects, but not
for nested objects, which are always are added with PID 0.

This patch ensures that nested extbase objects use either the
configured storage page configuration or inherit the storage page
from the parent object if no storage page configuration is defined.

Additionally, functional tests have been added to cover the
following scenarios:

  - PID inheritance from parent objects
  - Respecting persistence storagePid configuration
  - Respecting newRecordStoragePid configuration

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1321

  1. Torben Hansen uploaded patch set 1 08/02/24, 13:24

  2. core-ci voted on patch set 1 V +1 08/02/24, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62732

  3. Torben Hansen uploaded patch set 2 V +1 08/02/24, 19:20

  4. core-ci voted on patch set 2 V -1 08/02/24, 19:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62764

  5. Torben Hansen updated the commit message in patch set 3 V -1 08/03/24, 08:16

  6. core-ci voted on patch set 3 V -1 08/03/24, 08:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62788

  7. Torben Hansen rebased onto patch set 4 V -1 08/03/24, 08:26

  8. core-ci voted on patch set 4 V -1 08/03/24, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62790

  9. Torben Hansen uploaded patch set 5 V -1 08/03/24, 09:45

  10. Torben Hansen uploaded patch set 6 08/03/24, 09:49

  11. core-ci voted on patch set 5 V -1 08/03/24, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62794

  12. core-ci voted on patch set 6 V +1 08/03/24, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62796

  13. Torben Hansen updated the commit message in patch set 7 V +1 08/03/24, 13:45

  14. core-ci voted on patch set 7 V +1 08/03/24, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62803

  15. Benni Mack voted on patch set 7 CR +1 08/06/24, 07:38

  16. Benni Mack updated the commit message in patch set 8 CR +1 V +1 08/06/24, 07:38

  17. Benni Mack voted on patch set 8 CR +1 08/06/24, 07:38

  18. core-ci voted on patch set 8 V +1 08/06/24, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62877

  19. Christian Kuhn voted on patch set 8 CR +1 V +1 08/06/24, 07:50

  20. Benni Mack voted on patch set 8 CR +2 V +2 08/06/24, 08:24

  21. Benni Mack merged patch set 9 08/06/24, 08:24