Review main Merged

85491[BUGFIX] Move folder to _recycler_ on deletion if available

Friedemann Altrock CR +2 V +2 Normal +38 −13 updated 03/28/25, 17:17

Commit message

Deleting a file when a _recycler_ folder is available in the file
storage moves it there. Deleting a folder should do the same.

Note: the AfterFolderDeletedEvent is dispatched with `wasDeleted=false`
but the backend still shows a success flash message, same as for file
deletion.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Friedemann Altrock uploaded patch set 1 08/02/24, 13:35

  2. core-ci voted on patch set 1 V +1 08/02/24, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62734

  3. Benni Mack updated the commit message in patch set 2 V +1 10/18/24, 13:41

  4. Benni Mack rebased onto patch set 3 12/16/24, 15:20

  5. core-ci voted on patch set 3 V +1 12/16/24, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71202

  6. Benni Mack rebased onto patch set 4 V +1 03/28/25, 12:29

  7. core-ci voted on patch set 4 V +1 03/28/25, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76587

  8. Benni Mack commented on patch set 4 CR +1 V +1 03/28/25, 13:33

    Fix works for me, but only works for empty folders...
  9. Garvin Hicking voted on patch set 4 CR +1 V +1 03/28/25, 17:01

  10. Benni Mack voted on patch set 4 CR +2 03/28/25, 17:17

  11. Benni Mack voted on patch set 4 V +2 03/28/25, 17:17

  12. Benni Mack merged patch set 5 03/28/25, 17:17